1406715 - In HTML5 fullscreen mode, the message box with the text "[...] is now full screen" moves the whole screen with it when it animates away

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Markus Stange [:mstange]]

Steps to reproduce:
 1. Enable webrender.
 2. Go to http://blogs.sitepointstatic.com/examples/tech/full-screen/index2.html
 3. Click the picture.
 4. Wait for the overlay "sitepointstatic.com is now full screen" to go away.

When it goes away, the whole screen briefly moves upwards and then snaps back down.

This can be retriggered by moving the mouse to the top edge of the screen, which will make the message appear again.

The same happens with fullscreen video on YouTube, for example.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Is this Mac only?

Comment 2

[Markus Stange [:mstange]]

I've reproduced this on both Mac and Windows.

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1406715 - Use the RenderFrameParent's content rect as the bounds of the webrender iframe display item.

It was using the visible rect of the display item before, which can be larger
than the frame for various reasons. But the bounds we pass for the webrender
iframe item determines the iframe's position, so it needs to be informed by the
layout position of the frame, not by circumstances of the paint.

Review commit: https://reviewboard.mozilla.org/r/193222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193222/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8922206 [details]
Bug 1406715 - Use the RenderFrameParent's content rect as the bounds of the webrender iframe display item.

https://reviewboard.mozilla.org/r/193222/#review198556

Nice catch! Do you know if this also fixes the various bugs where web content ends up drawing over the toolbars and other UI? e.g. bug 1396298, bug 1403750

Comment 5

[Markus Stange [:mstange]]

It fixes bug 1411959. The bugs that you mentioned seem to have been fixed already.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9613617f268
Use the RenderFrameParent's content rect as the bounds of the webrender iframe display item. r=kats

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d9613617f268