Closed Bug 1406831 Opened 3 years ago Closed 3 years ago

tighten AssertOnGraphThreadOrNotRunning() check

Categories

(Core :: Audio/Video: MediaStreamGraph, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(3 files)

No description provided.
Comment on attachment 8916486 [details]
bug 1406831 simplify AssertOnGraphThreadOrNotRunning()

https://reviewboard.mozilla.org/r/187614/#review192646
Attachment #8916486 - Flags: review?(apehrson) → review+
Comment on attachment 8916487 [details]
bug 1406831 tighten AssertOnGraphThreadOrNotRunning() to not accept graph thread after mDetectedNotRunning

https://reviewboard.mozilla.org/r/187616/#review192648
Attachment #8916487 - Flags: review?(apehrson) → review+
Comment on attachment 8916488 [details]
bug 1406831 don't tolerate just owning the monitor if AssertOnGraphThreadOrNotRunning() is not called on the correct thread

https://reviewboard.mozilla.org/r/187618/#review192652
Attachment #8916488 - Flags: review?(apehrson) → review+
Rank: 19
Priority: -- → P2
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6348624e870
simplify AssertOnGraphThreadOrNotRunning() r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/f534d96564e0
tighten AssertOnGraphThreadOrNotRunning() to not accept graph thread after mDetectedNotRunning r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/e3f39de40209
don't tolerate just owning the monitor if AssertOnGraphThreadOrNotRunning() is not called on the correct thread r=pehrsons
Depends on: 1410043
You need to log in before you can comment on or make changes to this bug.