Closed
Bug 1406831
Opened 7 years ago
Closed 7 years ago
tighten AssertOnGraphThreadOrNotRunning() check
Categories
(Core :: Audio/Video: MediaStreamGraph, enhancement, P2)
Core
Audio/Video: MediaStreamGraph
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(3 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d388956e7dcf1f14e34b5ddaf0aa4182223a988e
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8916486 [details] bug 1406831 simplify AssertOnGraphThreadOrNotRunning() https://reviewboard.mozilla.org/r/187614/#review192646
Attachment #8916486 -
Flags: review?(apehrson) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8916487 [details] bug 1406831 tighten AssertOnGraphThreadOrNotRunning() to not accept graph thread after mDetectedNotRunning https://reviewboard.mozilla.org/r/187616/#review192648
Attachment #8916487 -
Flags: review?(apehrson) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8916488 [details] bug 1406831 don't tolerate just owning the monitor if AssertOnGraphThreadOrNotRunning() is not called on the correct thread https://reviewboard.mozilla.org/r/187618/#review192652
Attachment #8916488 -
Flags: review?(apehrson) → review+
Updated•7 years ago
|
Rank: 19
Priority: -- → P2
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f6348624e870 simplify AssertOnGraphThreadOrNotRunning() r=pehrsons https://hg.mozilla.org/integration/autoland/rev/f534d96564e0 tighten AssertOnGraphThreadOrNotRunning() to not accept graph thread after mDetectedNotRunning r=pehrsons https://hg.mozilla.org/integration/autoland/rev/e3f39de40209 don't tolerate just owning the monitor if AssertOnGraphThreadOrNotRunning() is not called on the correct thread r=pehrsons
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f6348624e870 https://hg.mozilla.org/mozilla-central/rev/f534d96564e0 https://hg.mozilla.org/mozilla-central/rev/e3f39de40209
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•