1410043 - Intermittent dom/media/webaudio/test/test_WebAudioMemoryReporting.html | Assertion failure: OnGraphThreadOrNotRunning(), at /builds/worker/workspace/build/src/dom/media/MediaStreamGraph.h:1372

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=138135044&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/HCSCtyBoRy2Okxzr7mIBWA/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: bug 1410043 remove over-zealous graph-thread assert in SetCurrentDriver()

The reverts to accepting ownership of the monitor regardless of the thread, as
accepted prior to
https://hg.mozilla.org/mozilla-central/rev/e3f39de40209#l1.25

As indicated in the SetCurrentDriver() documentation, it can be called on the
main thread during Revive() before another graph thread is started.

At that point mLifecycleState = LIFECYCLE_RUNNING, and so it is not easy to
adjust AssertOnGraphThreadOrNotRunning() to accept this situation without
making it much more liberal.

An alternative would be to change the Revive() methods to set mDriver
directly, but that would differ from the usual driver-switching pattern.

Review commit: https://reviewboard.mozilla.org/r/191472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191472/

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8920468 [details]
bug 1410043 remove over-zealous graph-thread assert in SetCurrentDriver()

https://reviewboard.mozilla.org/r/191472/#review196776

Comment 3

[Intermittent Failures Robot]

11 failures in 864 pushes (0.013 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 5
* mozilla-central: 4
* try: 1
* autoland: 1

Platform breakdown:
* linux64: 6
* linux64-stylo-disabled: 2
* linux32-stylo-disabled: 2
* linux64-ccov: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1410043&startday=2017-10-16&endday=2017-10-22&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6101f641ea7
remove over-zealous graph-thread assert in SetCurrentDriver() r=pehrsons

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b6101f641ea7

Comment 6

[Intermittent Failures Robot]

7 failures in 912 pushes (0.008 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 5
* mozilla-inbound: 2

Platform breakdown:
* linux64: 4
* linux64-stylo-disabled: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1410043&startday=2017-10-23&endday=2017-10-29&tree=all