1406964 - Fading out the toolbar buttons should use a quicker easing function

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The patch in bug 1390313 landed without declaring an explicit timing function. Therefore it uses `ease`. This animation plays pretty slow in the middle. I think it looks a lot better when we speed up more at the start, which is what the standard "photon" animation-easing-function uses.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

Review commit: https://reviewboard.mozilla.org/r/187748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187748/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Pushed to tryserver at https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb75ed7edb36. I'll request ui-review from epang once the builds are ready.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8916655 [details]
Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

https://reviewboard.mozilla.org/r/187748/#review192828

r=me on the assumption of ui-r+

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8916655 [details]
Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

Windows x64: https://queue.taskcluster.net/v1/task/PShqowoNRFWIZ8HrtyWk7A/runs/0/artifacts/public/build/target.zip
OSX: https://queue.taskcluster.net/v1/task/FmF_uNrZSuaU2swOjAl92w/runs/0/artifacts/public/build/target.dmg
Linux 64: https://queue.taskcluster.net/v1/task/ZFremWCITymLlwYX-g4QTw/runs/0/artifacts/public/build/target.tar.bz2

Comment 5

[Aaron Benson]

Comment on attachment 8916655 [details]
Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

Looks great!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbdf62ee0589
Fading out the toolbar buttons should use a quicker easing function. r=Gijs

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8916655 [details]
Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

Approval Request Comment
[Feature/Bug causing the regression]: follow-up to bug 1390313
[User impact if declined]: animation will appear slower than it should
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: just changes the CSS property for the animation timing function (one line CSS change, only visual)
[String changes made/needed]: none

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bbdf62ee0589

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916655 [details]
Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

Photon polish, beta57+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Bug 1390313 hasn't been uplifted to Beta (nor is it nominated for approval), so this patch doesn't apply?

Comment 11

[:Gijs (he/him)]

FWIW, I didn't think 1390313 was crucial for 57, and given bug 1407435 I'm not sure it's a good idea to uplift all of it now...

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Sorry I missed that bug 1390313 wasn't uplifted nor planned for uplift. I agree with holding back bug 1390313.