Closed Bug 1406964 Opened 3 years ago Closed 3 years ago

Fading out the toolbar buttons should use a quicker easing function

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

The patch in bug 1390313 landed without declaring an explicit timing function. Therefore it uses `ease`. This animation plays pretty slow in the middle. I think it looks a lot better when we speed up more at the start, which is what the standard "photon" animation-easing-function uses.
Pushed to tryserver at https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb75ed7edb36. I'll request ui-review from epang once the builds are ready.
Priority: -- → P3
Comment on attachment 8916655 [details]
Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

https://reviewboard.mozilla.org/r/187748/#review192828

r=me on the assumption of ui-r+
Attachment #8916655 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8916655 [details]
Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

Looks great!
Attachment #8916655 - Flags: ui-review?(bbell)
Attachment #8916655 - Flags: ui-review?(abenson)
Attachment #8916655 - Flags: ui-review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbdf62ee0589
Fading out the toolbar buttons should use a quicker easing function. r=Gijs
Comment on attachment 8916655 [details]
Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

Approval Request Comment
[Feature/Bug causing the regression]: follow-up to bug 1390313
[User impact if declined]: animation will appear slower than it should
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: just changes the CSS property for the animation timing function (one line CSS change, only visual)
[String changes made/needed]: none
Attachment #8916655 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/bbdf62ee0589
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8916655 [details]
Bug 1406964 - Fading out the toolbar buttons should use a quicker easing function.

Photon polish, beta57+
Attachment #8916655 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Bug 1390313 hasn't been uplifted to Beta (nor is it nominated for approval), so this patch doesn't apply?
Flags: needinfo?(jaws)
FWIW, I didn't think 1390313 was crucial for 57, and given bug 1407435 I'm not sure it's a good idea to uplift all of it now...
Sorry I missed that bug 1390313 wasn't uplifted nor planned for uplift. I agree with holding back bug 1390313.
Flags: needinfo?(jaws)
You need to log in before you can comment on or make changes to this bug.