1407055 - Removed registry-installed extension is shown on first Firefox run

Status: NEW

(Toolkit :: Add-ons Manager, defect, P3)

Description

[krest143]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce:

Reproduced on Firefox 56.0.1 20171002220106. Can be reproduced on any extension
Steps:
1) Install extension via registry by adding entry in HKEY_CURRENT_USER\Software\Mozilla\Firefox\Extensions.
2) Run Firefox and enable extension after Firefox asks. Close Firefox
3) Uninstall extension by removing it's registry entry
4) Run Firefox


Actual results:

Extension is still shown and working. about:addons and about:support doesn't show it in list though.


Expected results:

Extension is removed from Firefox

Comment 1

[Andy McKay]

Krupa, could someone try to reproduce this please? The words "Extension is still shown and working. about:addons and about:support doesn't show it in list though." worry me a bit :)

Comment 2

[krupa raj [:krupa--use this to needinfo]]

(In reply to Andy McKay [:andym] from comment #1)
> Krupa, could someone try to reproduce this please? The words "Extension is
> still shown and working. about:addons and about:support doesn't show it in
> list though." worry me a bit :)

yes, I will have this tested.

Comment 3

[CosminB]

Attachment: Bug1407055.gif

I was able to reproduce this issue on Firefox 56.0.1 (20171002220106), Firefox 57.0b9 (20171016185129) and Firefox 58.0a1 (20171016220427) under Windows 7 64-bit.

The extension is not visible in about:addons and about:support tabs, but it is working from the toolbar menu.
At a second restart of the browser after the extension was removed it is not visible anymore.

Please see the attached video.

Comment 4

[Andy McKay]

Any idea on priority Andrew, if this has been happening since 56, it seems pretty low priority. Although the expected outcome here isn't clear to me.

Comment 5

[Andrew Swan [:aswan]]

Caveat: I haven't dug in to figure out how tricky this is but I think the desired behavior is that the extension is removed when the registry key is removed.  However Kris has done a bunch of work to avoid doing a bunch of I/O during startup just for sideloaded extensions, I think that the removal should not happen synchronously during startup.  In the case where the registry entry is removed but the xpi sticks around, the removal should happen when we get around to scanning the registry, some time after startup.  In no case should an extension be in the half-installed state described in previous comments.