Hi, I'm new to open-source projects and would like to take this up. Please guide/mentor me through this.
(In reply to Shobhit Chittora from comment #1) > Hi, > I'm new to open-source projects and would like to take this up. Please > guide/mentor me through this. Hi! Have you pulled / downloaded the source code? Have you built Firefox yet?
Hey! I'm downloading the dependencies and will try to build now. Thanks for your patience.
Hey Dao -- I just went through and fixed the issue. Please let me know if my changes were sufficient :)
(In reply to nikshepsvn from comment #4) > Created attachment 8917154 [details] [diff] [review] > removed_obsolete_BrowserStartup_and_BrowserShutdown_functions > > Hey Dao -- I just went through and fixed the issue. Please let me know if my > changes were sufficient :) This looks like an export of mozilla-central tip rather than your patch. Have you committed your changes before trying to export them?
Flags: needinfo?(dao+bmo) → needinfo?(nikshepsvn)
oh my bad -- I forgot to commit them! Will commit and upload a patch soon -- sorry!
fixed patch file
Comment on attachment 8917441 [details] [diff] [review] removedObseleteBrowserStartupAndShutdownfunctions.patch Looks good, thanks!
Attachment #8917441 - Flags: review?(dao+bmo) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/893e45de11ab Remove obsolete BrowserStartup and BrowserShutdown functions. r=dao
woot, thank you!
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.