Closed Bug 1407195 Opened 4 years ago Closed 4 years ago

Remove obsolete BrowserStartup and BrowserShutdown functions

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: dao, Assigned: nikshepsvn, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file, 1 obsolete file)

removedObseleteBrowserStartupAndShutdownfunctions.patch
1.29 KB, patch
dao
: review+
Details | Diff | Splinter Review 
Hi,
I'm new to open-source projects and would like to take this up. Please guide/mentor me through this.
(In reply to Shobhit Chittora from comment #1)
> Hi,
> I'm new to open-source projects and would like to take this up. Please
> guide/mentor me through this.

Hi! Have you pulled / downloaded the source code? Have you built Firefox yet?
Flags: needinfo?(chittorashobhit)
Hey! I'm downloading the dependencies and will try to build now. Thanks for your patience.
Flags: needinfo?(chittorashobhit)
Hey Dao -- I just went through and fixed the issue. Please let me know if my changes were sufficient :)
Flags: needinfo?(dao+bmo)
(In reply to nikshepsvn from comment #4)
> Created attachment 8917154 [details] [diff] [review]
> removed_obsolete_BrowserStartup_and_BrowserShutdown_functions
> 
> Hey Dao -- I just went through and fixed the issue. Please let me know if my
> changes were sufficient :)

This looks like an export of mozilla-central tip rather than your patch. Have you committed your changes before trying to export them?
Flags: needinfo?(dao+bmo) → needinfo?(nikshepsvn)
Assignee: nobody → nikshepsvn
oh my bad -- I forgot to commit them! Will commit and upload a patch soon -- sorry!
Flags: needinfo?(nikshepsvn)
fixed patch file
Attachment #8917154 - Attachment is obsolete: true
Flags: needinfo?(dao+bmo)
Attachment #8917441 - Flags: review?(dao+bmo)
Comment on attachment 8917441 [details] [diff] [review]
removedObseleteBrowserStartupAndShutdownfunctions.patch

Looks good, thanks!
Flags: needinfo?(dao+bmo)
Attachment #8917441 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/893e45de11ab
Remove obsolete BrowserStartup and BrowserShutdown functions. r=dao
woot, thank you!
https://hg.mozilla.org/mozilla-central/rev/893e45de11ab
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Blocks: 1387013
No longer depends on: 1387013
You need to log in before you can comment on or make changes to this bug.