14072 - Sending a message when the smpt pref is empty crash Apprunner

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Jean-Francois Ducarroz]

If I try to send a message when my smtp pref is set to an empty string result in a crash of Apprunner.

Comment 1

[Scott MacGregor]

Jean-Francois, can you post a stack trace for me? Thanks!

Comment 2

[Scott MacGregor]

In addition to a stack trace, exactly which smtp pref needs to be empty?
identity.id1.smtp_server? or identity.id1.smtp_name, etc..

Thanks.

Comment 3

[Jean-Francois Ducarroz]

you need to clear identity.id1.smtp_server.

Comment 4

[Jean-Francois Ducarroz]

Just before crashing, I get the following assert message:

 PreCondition: "You can't dereference a NULL nsCOMPtr with operator->()." (mRawPtr != 0) at file nsCOMPtr.h, line
588

at this point (befor the crash) the stack trace is the following:

...
  04787870    PPC  16E4DDAC  nsMsgComposeAndSend::DeliverFileAsMail()+00740
  04787750    PPC  16E59E7C  nsSmtpService::SendMailMessage(nsIFileSpec*, const char*, nsIUrlListener*,
nsISmtpServer*, nsIURI**)+0021C
  04787690    PPC  16E5A3B0  NS_MsgLoadMailtoUrl(nsIURI*, nsISupports*)+000E0
  04787630    PPC  16E58C70  nsSmtpProtocol::LoadUrl(nsIURI*, nsISupports*)+003D0
  04787580    PPC  16E82160  nsMsgProtocol::LoadUrl(nsIURI*, nsISupports*)+0014C
  04787500    PPC  1757DF80  nsDebug::PreCondition(const char*, const char*, const char*, int)+00040

and then we crash right after. I will give you the line numer soon...

Comment 5

[Jean-Francois Ducarroz]

the assert/crash occurs in nsMsgProtocol::LoadUrl(nsIURI * aURL, nsISupports * aConsumer) at the line 219, I think
during the conversion of the parameters:

			m_channel->AsyncRead(m_startPosition, m_readCount, aURL,this /* stream observer */);

Comment 6

[Scott MacGregor]

I have a fix for this in my tree which I'll land monday. I added a new string to
the string bundle and was forced to revamp the compose string bundle code to
actually make it work!

I'm leaving soon and don't want to check in when I can't watch the tree.

No need to triage this bug on Monday as I have a fix.

Comment 7

[Jean-Francois Ducarroz]

Great, if you want, I can watch the tree for you... and eventually fix any bustage. Let me know...

Comment 8

[lchiang]

(target milestone is M11 or M12 - add to mail beta tracking bug)

Comment 9

[Scott MacGregor]

I've checked in a fix for this problem. To test, edit your prefs.js by hand and
where your smtp server name is, make that an empty string:
user_pref("mail.smtpserver.smtp1.hostname", "");

Try to send yourself a message. You'll get an alert asking you to properly
configure your smtp server and we don't crash.

However, while fixing this bug I noticed Bug #14561. The compose window is going
away and not coming back even though I'm reporting this error about a bad host
name. It used to be that the compose window would come back if you told it the
smtp code failed. So that part is now tracked in 14561.

Comment 10

[esther]

Using 19991003m10 on win98 and 19991001M10 on linux and mac this prompts with a
message if the smtp hostname is empty.  Bug scott found still happens. This one
will be verified