1407405 - browser_bug553455.js relies on broken Promise scheduling

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: test_fix_for_browser_bug553455.js

See bug 1193394 for the context.

The test should pass with the patch with and without the correct promise handling.

Comment 1

[Andrew Swan [:aswan]]

Comment on attachment 8917121 [details] [diff] [review]
test_fix_for_browser_bug553455.js

It seems reasonable enough to me but somebody more familiar with PopupNotifications should take a look.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8917121 [details] [diff] [review]
test_fix_for_browser_bug553455.js

Review of attachment 8917121 [details] [diff] [review]:
-----------------------------------------------------------------

Looks harmless. I haven't tested locally that the test passes, I assume you have verified or will verify with try before landing.

::: browser/base/content/test/general/browser_bug553455.js
@@ +25,5 @@
>  var gApp = document.getElementById("bundle_brand").getString("brandShortName");
>  var gVersion = Services.appinfo.version;
>  
> +function waitForTick() {
> +  return new Promise(resolve => executeSoon(resolve));

Bug 1407408 landed so it seems you no longer need this.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Couldn't immediately get TestUtils.jsm work in this test file, so I'll just land the patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ace9603cadb8
browser_bug553455.js relies on broken Promise scheduling, r=florian

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ace9603cadb8