1407719 - Fix failing xpcshell-test when building IB

Status: RESOLVED DUPLICATE of bug 1401528

(Instantbird Graveyard :: Other, defect)

Description

[arlolra]

Attachment: 0002-Fix-xpcshell-test-failures-when-building-IB.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce:

./mozilla/mach xpcshell-test

Comment 1

[arlolra]

Takes https://bugzilla.mozilla.org/show_bug.cgi?id=1407076 to run them.

Comment 2

[arlolra]

I'm assuming this is necessary because the global `this` is now constructed without Object in its prototype chain, so `____defineGetter__` is undefined.

Also, the choice of which places to change was made by doing `git grep "^this.__defineGetter__"`.

Comment 3

[Florian Quèze [:florian]]

(In reply to arlolra from comment #2)
> I'm assuming this is necessary because the global `this` is now constructed
> without Object in its prototype chain, so `____defineGetter__` is undefined.

The same change in m-c was done in bug 1363215.

> Also, the choice of which places to change was made by doing `git grep
> "^this.__defineGetter__"`.

The suite/ folder is SeaMonkey code, not Instantbird.

Comment 4

[arlolra]

> The suite/ folder is SeaMonkey code, not Instantbird.

Should I remove that then?  I didn't think it would hurt.

Comment 5

[Patrick Cloke [:clokep]]

(In reply to arlolra from comment #4)
> > The suite/ folder is SeaMonkey code, not Instantbird.
> 
> Should I remove that then?  I didn't think it would hurt.

Yes, either remove it or you need to get a separate review from one of the SeaMonkey people.

Comment 6

[arlolra]

Attachment: 0001-Bug-1407719-Fix-failing-xpcshell-test-when-building-.patch from comment 5

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7db605793963
Fix failing xpcshell-test when building IB

Comment 8

[Jorg K (CEST = GMT+2)]

I had to back that out since it caused test failures:
https://hg.mozilla.org/comm-central/rev/ef6dca7cc6cd3ee6c718489be624c606597b34df

TEST-UNEXPECTED-FAIL | chat/modules/test/test_filtering.js | test_permissiveMode - [test_permissiveMode : 222] "<span style=\\"font-style: normal; font-weight: normal; font-size: 15px; font-family: normal;\\">foo</span>" == "<span style=\\"font-family: normal; font-style: normal; font-weight: normal; font-size: 15px;\\">foo</span>"

Comment 9

[arlolra]

That's odd because it was necessary for the tests to pass locally for me.  Maybe the difference is because I'm building with `ac_add_options --enable-application=im`?

Comment 10

[arlolra]

Attachment: 0001-Bug-1407719-Fix-failing-xpcshell-test-when-building-.patch from comment 8

Updated the patch to remove the change to `chat/modules/test/test_filtering.js`

Note that this still results in a local failure for me but is safe to checkin.  Figuring out why the build target changes the result of that test can be a follow up.

Comment 11

[Jorg K (CEST = GMT+2)]

mozilla/mach xpcshell-test chat/modules/test/test_filtering.js
passes locally with the latest version so I'll get his landed RSN(TM).

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f4b4c62ffd1
Fix failing xpcshell-test when building IB. r=clokep

Comment 13

[Richard Marti (:Paenglab)]

This breaks the display of the chat messages (nothing shown).
Error in the console: TypeError: property "gTheme" is non-configurable and can't be deleted[Learn More]  imSmileys.jsm:20:5

Back-out of this patch fixes it for me.

Jörg, please can you back-out this patch?

Comment 14

[Jorg K (CEST = GMT+2)]

Backout as per comment #13 (I confirmed the malfunction and the "fix"):
https://hg.mozilla.org/comm-central/rev/85fa84e4ffdc2222075f8f69df5d81a90f798e49

I'll make sure we trigger a build so that's removed from the next Daily.

Comment 15

[Jorg K (CEST = GMT+2)]

The test failure from comment #8 will be fixed in bug 1420683.

Comment 16

[Jorg K (CEST = GMT+2)]

We'll fix the remaining test failure in bug 1401528, see bug 1401528 comment #95.