Closed Bug 1407961 Opened 7 years ago Closed 7 years ago

PWA Badge and Onboarding - Show home after creating PWA shortcut when API >26

Categories

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Product:
Firefox for Android Graveyard
Component:
Web Apps (PWAs)
Version:
56 Branch
Type:
defect

Tracking

(firefox58 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- verified

People

(Reporter: cnevinchen, Assigned: cnevinchen)

References

Details

(Whiteboard: [FNC][SPT58.3][INT][pwa-front-end] )

Attachments

(1 file)

Bug 1407961 - Show home after creating PWA.
59 bytes, text/x-review-board-request
snorp
: review+
Details 
improvement for bug 1405236
Attachment #8917776 - Flags: review?(snorp)
In API 26, there's an extra system prompt to let user add PWA shortcut to home screen. So we can't show the home screen directly after we request the shortcut.
This patch adds an extra intent as callback, so we can show the desktop after PWA shortcut create successfully.

Hi snorp, could you please help review? Thanks!
Flags: needinfo?(snorp)
Comment on attachment 8917776 [details]
Bug 1407961 - Show home after creating PWA.

https://reviewboard.mozilla.org/r/188714/#review194874
Attachment #8917776 - Flags: review?(snorp) → review+
Flags: needinfo?(snorp)
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa70e27ce039
Show home after creating PWA. r=snorp
ni mark so he knows this is landed
Flags: needinfo?(mliang)
Summary: Show home after creating PWA shortcut when API >26 → PWA Badge and Onboarding - Show home after creating PWA shortcut when API >26
Whiteboard: [pwa-front-end]
https://hg.mozilla.org/mozilla-central/rev/fa70e27ce039
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Priority: -- → P1
Whiteboard: [pwa-front-end] → [FNC][SPT58.3][INT][pwa-front-end]
Flags: needinfo?(mliang)
Verified as fixed on Nightly 58 (2017-11-03).
Device:
Google Pixel (Android 8.0)
Blocks: progressive-apps
Status: RESOLVED → VERIFIED
status-firefox58: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: