1408211 - update taskcluster builds to rust 1.20.0

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ralph Giles (:rillian)]

Bug 1396884 bumped the tooltool manifests to rust 1.20, but wasn't able to land because of other blocking issues. Since then, bug 1391427 moved packaging to a toolchain job running on taskcluster.

This bug is about bumping the rust builds under the new scheme.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1408211 - Update builders to rust 1.20.0.

New upstream stable release.

Also update the base revision for sccache so we don't need
to maintian a task description for win64-rust-1.19.

Review commit: https://reviewboard.mozilla.org/r/188942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188942/

Comment 2

[Mike Hommey [:glandium]]

I don't understand why you're filing a new bug. This *is* a dupe of bug 1396884.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Ralph Giles (:rillian) | needinfo me from comment #1)
> Created attachment 8918051 [details]
> Bug 1408211 - Update builders to rust 1.20.0.
> 
> New upstream stable release.
> 
> Also update the base revision for sccache so we don't need
> to maintian a task description for win64-rust-1.19.

As per bug 1408212, you don't want to update the rust version used to build sccache...

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8918051 [details]
Bug 1408211 - Update builders to rust 1.20.0.

https://reviewboard.mozilla.org/r/188942/#review194516

::: commit-message-25aad:5
(Diff revision 1)
> +Bug 1408211 - Update builders to rust 1.20.0. r=mshal
> +
> +New upstream stable release.
> +
> +Also update the base revision for sccache so we don't need

Does it work if you still use 1.19 for sccache as glandium suggests?

Comment 5

[Ralph Giles (:rillian)]

(In reply to Mike Hommey [:glandium] from comment #2)
> I don't understand why you're filing a new bug. This *is* a dupe of bug
> 1396884.

It was easier than convincing mozreview to take an updated patch.(In reply to Michael Shal [:mshal] from comment #4)

(In reply to Michael Shal [:mshal] from comment #4)
> Does it work if you still use 1.19 for sccache as glandium suggests?

Seems to! I'll update the patch.

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8918051 [details]
Bug 1408211 - Update builders to rust 1.20.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188942/diff/1-2/

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8918051 [details]
Bug 1408211 - Update builders to rust 1.20.0.

https://reviewboard.mozilla.org/r/188942/#review194516

> Does it work if you still use 1.19 for sccache as glandium suggests?

Looks green with that change.

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 8918051 [details]
Bug 1408211 - Update builders to rust 1.20.0.

https://reviewboard.mozilla.org/r/188942/#review194592

Comment 9

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 9e63a8b92fd7 -d 4f50c65e62c3: rebasing 426580:9e63a8b92fd7 "Bug 1408211 - Update builders to rust 1.20.0. r=mshal" (tip)
merging taskcluster/ci/toolchain/linux.yml
warning: conflicts while merging taskcluster/ci/toolchain/linux.yml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 10

[Ralph Giles (:rillian)]

Comment on attachment 8918051 [details]
Bug 1408211 - Update builders to rust 1.20.0.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188942/diff/2-3/

Comment 11

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s d6ca5a8c87c6 -d a0f88980b79c: rebasing 426583:d6ca5a8c87c6 "Bug 1408211 - Update builders to rust 1.20.0. r=mshal" (tip)
merging taskcluster/ci/toolchain/linux.yml
warning: conflicts while merging taskcluster/ci/toolchain/linux.yml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95dff4968a19
Update builders to rust 1.20.0. r=mshal

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/95dff4968a19

Comment 14

[Kartikaya Gupta (email:[e-mail])]

This may have introduced a crasher regression - see bug 1415151.