Closed Bug 1396884 Opened 2 years ago Closed 2 years ago

Update builders to rust 1.20.0

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rillian, Assigned: rillian)

References

()

Details

Attachments

(1 file)

A new upstream release is available.
Update is blocked on tooltool upload failures. Alternatively, bug 1391427 might address this a different way.
Attachment #8904616 - Flags: review?(mshal)
Comment on attachment 8904616 [details]
Bug 1396884 - Update builders to rust 1.20.0.

https://reviewboard.mozilla.org/r/176436/#review181842

We should definitely be using a toolchain task for this now. If you need to upgrade now to unblock other things, feel free to land this. But bug 1391427 will be worth the effort IMO.
Attachment #8904616 - Flags: review?(mshal) → review+
Agreed. I just wanted to get this in because it was quick to do. Thanks!
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f1782b58101
Update builders to rust 1.20.0. r=mshal
Backed out for OS X bustage:

https://hg.mozilla.org/integration/autoland/rev/5b1c1b8223bfee3d43039df59a428f3029bd2171

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6f1782b5810197fba21ce8d8579d7813e7dae94a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=128946531&repo=autoland

[task 2017-09-06T16:03:10.886278Z] 16:03:10     INFO -  #50 0x000000000042aa4d llvm::dsymutil::(anonymous namespace)::DwarfLinker::link(llvm::dsymutil::DebugMap const&) (/builds/worker/workspace/build/src/clang/bin/llvm-dsymutil+0x42aa4d)
[task 2017-09-06T16:03:10.886554Z] 16:03:10     INFO -  #51 0x00000000004285b9 llvm::dsymutil::linkDwarf(llvm::StringRef, llvm::dsymutil::DebugMap const&, llvm::dsymutil::LinkOptions const&) (/builds/worker/workspace/build/src/clang/bin/llvm-dsymutil+0x4285b9)
[task 2017-09-06T16:03:10.886786Z] 16:03:10     INFO -  #52 0x000000000041b938 main (/builds/worker/workspace/build/src/clang/bin/llvm-dsymutil+0x41b938)
[task 2017-09-06T16:03:10.887020Z] 16:03:10     INFO -  #53 0x00007ff370b34d1d __libc_start_main (/lib64/libc.so.6+0x1ed1d)
[task 2017-09-06T16:03:10.887297Z] 16:03:10     INFO -  #54 0x000000000041b1d9 _start (/builds/worker/workspace/build/src/clang/bin/llvm-dsymutil+0x41b1d9)
[task 2017-09-06T16:03:10.887547Z] 16:03:10     INFO -  Stack dump:
[task 2017-09-06T16:03:10.887812Z] 16:03:10     INFO -  0.	Program arguments: /builds/worker/workspace/build/src/clang/bin/llvm-dsymutil --arch=x86_64 /builds/worker/workspace/build/src/obj-firefox/toolkit/library/XUL
[task 2017-09-06T16:03:10.888090Z] 16:03:10     INFO -  Error running dsymutil: Command '['/builds/worker/workspace/build/src/clang/bin/llvm-dsymutil', '--arch=x86_64', '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/XUL']' returned non-zero exit status -11
[task 2017-09-06T16:03:10.888296Z] 16:03:10     INFO -  Traceback (most recent call last):
[task 2017-09-06T16:03:10.888520Z] 16:03:10     INFO -    File "/builds/worker/workspace/build/src/toolkit/crashreporter/tools/symbolstore.py", line 888, in <module>
[task 2017-09-06T16:03:10.888755Z] 16:03:10     INFO -      main()
[task 2017-09-06T16:03:10.889048Z] 16:03:10     INFO -    File "/builds/worker/workspace/build/src/toolkit/crashreporter/tools/symbolstore.py", line 884, in main
[task 2017-09-06T16:03:10.889263Z] 16:03:10     INFO -      dumper.Process(args[2])
[task 2017-09-06T16:03:10.889539Z] 16:03:10     INFO -    File "/builds/worker/workspace/build/src/toolkit/crashreporter/tools/symbolstore.py", line 501, in Process
[task 2017-09-06T16:03:10.889766Z] 16:03:10     INFO -      self.ProcessFile(file_to_process)
[task 2017-09-06T16:03:10.890061Z] 16:03:10     INFO -    File "/builds/worker/workspace/build/src/toolkit/crashreporter/tools/symbolstore.py", line 758, in ProcessFile
[task 2017-09-06T16:03:10.890290Z] 16:03:10     INFO -      dsymbundle = self.GenerateDSYM(file)
[task 2017-09-06T16:03:10.890561Z] 16:03:10     INFO -    File "/builds/worker/workspace/build/src/toolkit/crashreporter/tools/symbolstore.py", line 792, in GenerateDSYM
[task 2017-09-06T16:03:10.890813Z] 16:03:10     INFO -      subprocess.check_call(cmd, stdout=open(os.devnull, 'w'))
[task 2017-09-06T16:03:10.891029Z] 16:03:10     INFO -    File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
[task 2017-09-06T16:03:10.891198Z] 16:03:10     INFO -      raise CalledProcessError(retcode, cmd)
[task 2017-09-06T16:03:10.891431Z] 16:03:10     INFO -  subprocess.CalledProcessError: Command '['/builds/worker/workspace/build/src/clang/bin/llvm-dsymutil', '--arch=x86_64', '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/XUL']' returned non-zero exit status -11
Valgrind log: https://treeherder.mozilla.org/logviewer.html#?job_id=128946539&repo=autoland
> TEST-UNEXPECTED-FAIL | valgrind-test | Conditional jump or move depends on uninitialised value(s) at selectors::matching::matches_complex_selector_internal / selectors::matching::matches_complex_selector / ?!? / ?!?
Flags: needinfo?(giles)
Oops, missed this among the spurious windows build failures on the try push.
Flags: needinfo?(giles)
Depends on: 1397382
Depends on: 1397384
Depends on: 1394696
Is this blocked? https://github.com/servo/servo/pull/18809 updates the bitflags crate to version 1.0, which uses associated constants, which are stabilized in Rust 1.20.
Depends on: 1408211
Sorry for not updating the bug. Yes this is blocked by dsymutil crashes on mac targets (bug 1381043 &c.) and tc permission problems on Windows (bug 1408211).
Blocks: 1408567
This bug is resolved by bug 1408211. Bumping the minimum rust version to 1.20.0 in bug 1408567 is on the autoland branch, so it should be safe to go ahead and merge code depending on 1.20.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.