Closed Bug 1408301 Opened 2 years ago Closed 2 years ago

unship CSSStyleDeclaration::getPropertyCSSValue

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- ?
firefox62 --- fixed

People

(Reporter: heycam, Assigned: emilio)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file, 1 obsolete file)

We should look into whether we can safely unship CSSStyleDeclarationValue::getPropertyCSSValue, or at least greatly simplify the kinds of objects that we return.  According to MDN, WebKit is the only other engine that supports this method, but I haven't done any web compat investigations myself.

This would simplify bug 1408300.
Priority: -- → P3
Flags: needinfo?(emilio)
Back in bug 474655 I tried to land a deprecation warning, but IIRC our chrome hit it too much.
Depends on: 1445598
Depends on: 1447039
Attached patch patch (obsolete) — Splinter Review
Jumping the gun somewhat, but here's a patch in the event that we can move forward with this.
So, usage in nightly looks not high (0.005%) so far according to:

  https://georgf.github.io/usecounters/index.html#kind=document&group=DEPRECATED&channel=nightly&version=61

That is non-zero though. After talking with Boris I think it makes sense to disable on nightly and see if it breaks something, and only get data from beta for this use counter.
Flags: needinfo?(emilio)
Depends on: 1448415
Blocks: 1459871
Assignee: nobody → emilio
Attachment #8960532 - Attachment is obsolete: true
Comment on attachment 8973967 [details]
Bug 1408301: Remove getPropertyCSSValue.

https://reviewboard.mozilla.org/r/242312/#review249040

r=me, but do you mind filing a followup for those various editor things whose comments you are removing to use the CSS Typed OM once it exists?  Probably depending on the bug for CSS Typed OM if we have it...
Attachment #8973967 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #8)
> Comment on attachment 8973967 [details]
> Bug 1408301: Remove getPropertyCSSValue.
> 
> https://reviewboard.mozilla.org/r/242312/#review249040
> 
> r=me, but do you mind filing a followup for those various editor things
> whose comments you are removing to use the CSS Typed OM once it exists? 
> Probably depending on the bug for CSS Typed OM if we have it...

Filed a couple bugs depending on bug 1278697.
Blocks: 1461092
https://hg.mozilla.org/mozilla-central/rev/6f0eb5c180c1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Blocks: 1494622
You need to log in before you can comment on or make changes to this bug.