Closed Bug 1408301 Opened 2 years ago Closed 2 years ago
Declaration::get Property CSSValue
We should look into whether we can safely unship CSSStyleDeclarationValue::getPropertyCSSValue, or at least greatly simplify the kinds of objects that we return. According to MDN, WebKit is the only other engine that supports this method, but I haven't done any web compat investigations myself. This would simplify bug 1408300.
Back in bug 474655 I tried to land a deprecation warning, but IIRC our chrome hit it too much.
2 years ago
Jumping the gun somewhat, but here's a patch in the event that we can move forward with this.
So, usage in nightly looks not high (0.005%) so far according to: https://georgf.github.io/usecounters/index.html#kind=document&group=DEPRECATED&channel=nightly&version=61 That is non-zero though. After talking with Boris I think it makes sense to disable on nightly and see if it breaks something, and only get data from beta for this use counter.
Attachment #8960532 - Attachment is obsolete: true
Comment on attachment 8973967 [details] Bug 1408301: Remove getPropertyCSSValue. https://reviewboard.mozilla.org/r/242312/#review249040 r=me, but do you mind filing a followup for those various editor things whose comments you are removing to use the CSS Typed OM once it exists? Probably depending on the bug for CSS Typed OM if we have it...
Attachment #8973967 - Flags: review?(bzbarsky) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0eb5c180c1 Remove getPropertyCSSValue. r=bz
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #8) > Comment on attachment 8973967 [details] > Bug 1408301: Remove getPropertyCSSValue. > > https://reviewboard.mozilla.org/r/242312/#review249040 > > r=me, but do you mind filing a followup for those various editor things > whose comments you are removing to use the CSS Typed OM once it exists? > Probably depending on the bug for CSS Typed OM if we have it... Filed a couple bugs depending on bug 1278697.
Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/cssstyledeclaration-getpropertycssvalue-has-been-removed/
Compat data is updated for this: https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleDeclaration/getPropertyCSSValue#Browser_compatibility, marking dev-doc-complete.
You need to log in before you can comment on or make changes to this bug.