Closed
Bug 1408301
Opened 7 years ago
Closed 7 years ago
unship CSSStyleDeclaration::getPropertyCSSValue
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla62
People
(Reporter: heycam, Assigned: emilio)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file, 1 obsolete file)
We should look into whether we can safely unship CSSStyleDeclarationValue::getPropertyCSSValue, or at least greatly simplify the kinds of objects that we return. According to MDN, WebKit is the only other engine that supports this method, but I haven't done any web compat investigations myself.
This would simplify bug 1408300.
Reporter | ||
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Updated•7 years ago
|
Comment 1•7 years ago
|
||
status-firefox59:
--- → ?
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(emilio)
Back in bug 474655 I tried to land a deprecation warning, but IIRC our chrome hit it too much.
Updated•7 years ago
|
Keywords: site-compat
![]() |
||
Comment 3•7 years ago
|
||
Jumping the gun somewhat, but here's a patch in the event that we can move forward with this.
![]() |
||
Comment 4•7 years ago
|
||
Assignee | ||
Comment 5•7 years ago
|
||
So, usage in nightly looks not high (0.005%) so far according to:
https://georgf.github.io/usecounters/index.html#kind=document&group=DEPRECATED&channel=nightly&version=61
That is non-zero though. After talking with Boris I think it makes sense to disable on nightly and see if it breaks something, and only get data from beta for this use counter.
Flags: needinfo?(emilio)
Updated•7 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → emilio
Assignee | ||
Updated•7 years ago
|
Attachment #8960532 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
![]() |
||
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8973967 [details]
Bug 1408301: Remove getPropertyCSSValue.
https://reviewboard.mozilla.org/r/242312/#review249040
r=me, but do you mind filing a followup for those various editor things whose comments you are removing to use the CSS Typed OM once it exists? Probably depending on the bug for CSS Typed OM if we have it...
Attachment #8973967 -
Flags: review?(bzbarsky) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0eb5c180c1
Remove getPropertyCSSValue. r=bz
Assignee | ||
Comment 10•7 years ago
|
||
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #8)
> Comment on attachment 8973967 [details]
> Bug 1408301: Remove getPropertyCSSValue.
>
> https://reviewboard.mozilla.org/r/242312/#review249040
>
> r=me, but do you mind filing a followup for those various editor things
> whose comments you are removing to use the CSS Typed OM once it exists?
> Probably depending on the bug for CSS Typed OM if we have it...
Filed a couple bugs depending on bug 1278697.
![]() |
||
Comment 11•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment 12•7 years ago
|
||
Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/cssstyledeclaration-getpropertycssvalue-has-been-removed/
Comment 13•7 years ago
|
||
Compat data is updated for this: https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleDeclaration/getPropertyCSSValue#Browser_compatibility, marking dev-doc-complete.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•