Closed
Bug 1448415
Opened 7 years ago
Closed 7 years ago
Hide getPropertyCSSValue on Nightly.
Categories
(Core :: DOM: CSS Object Model, defect)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
No description provided.
Keywords: site-compat
Comment hidden (mozreview-request) |
![]() |
||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8961874 [details]
Bug 1448415: Hide getPropertyCSSValue on nightly.
https://reviewboard.mozilla.org/r/230714/#review236192
::: layout/style/test/mochitest.ini:95
(Diff revision 1)
> [test_bug200089.html]
> [test_bug221428.html]
> [test_bug229915.html]
> [test_bug302186.html]
> [test_bug319381.html]
> +prefs = layout.css.getPropertyCSSValue.enabled=true
Maybe add a comment that when that pref is removed the getPropertyCSSValue parts of the test should be removed but the rest should stay? Same for the other test annotations.
Attachment #8961874 -
Flags: review?(bzbarsky) → review+
Is it perhaps better to use the EARLY_BETA_OR_EARLIER switch, like some other stuff?
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Kohei Yoshino [:kohei] from comment #3)
> Is it perhaps better to use the EARLY_BETA_OR_EARLIER switch, like some
> other stuff?
Perhaps, problem with that is that then the use counter is not useful in beta...
![]() |
||
Comment 5•7 years ago
|
||
Right; that's why it's not a good idea: it will mess up the use counter values.
Updated•7 years ago
|
Keywords: dev-doc-needed
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00571dd5c5ee
Hide getPropertyCSSValue on nightly. r=bz
Updated the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/cssstyledeclaration-getpropertycssvalue-has-been-deprecated/
Comment 8•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 9•7 years ago
|
||
I have added a note about it into our experimental features page, and added information about the removal to the method page itself:
https://developer.mozilla.org/en-US/Firefox/Experimental_features
https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleDeclaration/getPropertyCSSValue
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•