Closed
Bug 1408362
Opened 7 years ago
Closed 7 years ago
Remove the tabbrowser-tabs class
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: dao, Assigned: aruna.maurya12, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file)
|
5.24 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
This was kept for backward compatibility: http://searchfox.org/mozilla-central/rev/ed1d5223adcdc07e9a2589ee20f4e5ee91b4df10/browser/base/content/browser.xul#637 We should remove this now and instead use the id selector here: http://searchfox.org/mozilla-central/search?q=.tabbrowser-tabs&case=true
|
Reporter | |
Comment 4•7 years ago
|
||
Do you have a copy of the code base? Have you built Firefox yet? You need to remove class="tabbrowser-tabs" in browser/base/content/browser.xul and replace .tabbrowser-tabs with #tabbrowser-tabs everywhere. See also the links in comment 0.
There's one more thing that I wanted to ask, I did my first bug and it is currently under review. It hasn't been merged.I had used Mercurial Queues to submit the first patch. My query is how can I do this when my patch is still under review.
|
|
Reporter | |
Comment 7•7 years ago
|
||
There are several ways to do this. For instance, you could remove your old commits with hg strip: https://www.mercurial-scm.org/wiki/StripExtension You would later have to re-import them in order to work with them again.
|
|
Reporter | |
Comment 9•7 years ago
|
||
Yes, there's a Git mirror for mozilla-central: https://github.com/mozilla/gecko-dev
|
Assignee | |
Comment 10•7 years ago
|
||
If I am using Git to do it, I need to make a pull request? right? I need not attach any attachments here?
|
|
Reporter | |
Comment 11•7 years ago
|
||
No, the Git mirror is read-only. Please export the patch from git and attach it here.
|
|
Assignee | |
Comment 12•7 years ago
|
||
But still I can make the changes, commit and then export the patch.? right?
|
|
Reporter | |
Comment 13•7 years ago
|
||
Correct :)
|
|
Assignee | |
Comment 14•7 years ago
|
||
Hey!! The Git mirror repositery is failing to clone. Is it a possibility of resolving it without cloning it.
|
|
Reporter | |
Comment 15•7 years ago
|
||
No, I don't think so. How does it fail?
|
|
Assignee | |
Comment 16•7 years ago
|
||
|
|
Reporter | |
Comment 17•7 years ago
|
||
Comment on attachment 8918811 [details] [diff] [review] Bug-1408362.patch Looks good. Thanks!
Attachment #8918811 -
Flags: review+
|
||
Comment 18•7 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/613d38c5f98c Remove the tabbrowser-tabs class. r=dao
|
||
Comment 19•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/613d38c5f98c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in
before you can comment on or make changes to this bug.
Description
•