1408362 - Remove the tabbrowser-tabs class

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Dão Gottwald [:dao]]

This was kept for backward compatibility:

http://searchfox.org/mozilla-central/rev/ed1d5223adcdc07e9a2589ee20f4e5ee91b4df10/browser/base/content/browser.xul#637

We should remove this now and instead use the id selector here:

http://searchfox.org/mozilla-central/search?q=.tabbrowser-tabs&case=true

Comment 1

[Aruna]

Hey!!Can I work on this?

Comment 2

[Dão Gottwald [:dao]]

Sure!

Comment 3

[Aruna]

Could you elaborate a bit?

Comment 4

[Dão Gottwald [:dao]]

Do you have a copy of the code base? Have you built Firefox yet?

You need to remove class="tabbrowser-tabs" in browser/base/content/browser.xul and replace .tabbrowser-tabs with #tabbrowser-tabs everywhere. See also the links in comment 0.

Comment 5

[Aruna]

Yes, I have built the source code for Firefox.

Comment 6

[Aruna]

There's one more thing that I wanted to ask, I did my first bug and it is currently under review. It hasn't been merged.I had used Mercurial Queues to submit the first patch. My query is how can I do this when my patch is still under review.

Comment 7

[Dão Gottwald [:dao]]

There are several ways to do this. For instance, you could remove your old commits with hg strip:

https://www.mercurial-scm.org/wiki/StripExtension

You would later have to re-import them in order to work with them again.

Comment 8

[Aruna]

Can I do it using Git?

Comment 9

[Dão Gottwald [:dao]]

Yes, there's a Git mirror for mozilla-central: https://github.com/mozilla/gecko-dev

Comment 10

[Aruna]

If I am using Git to do it, I need to make a pull request? right? I need not attach any attachments here?

Comment 11

[Dão Gottwald [:dao]]

No, the Git mirror is read-only. Please export the patch from git and attach it here.

Comment 12

[Aruna]

But still I can make the changes, commit and then export the patch.? right?

Comment 13

[Dão Gottwald [:dao]]

Correct :)

Comment 14

[Aruna]

Hey!! The Git mirror repositery is failing to clone. Is it a possibility of resolving it without cloning it.

Comment 15

[Dão Gottwald [:dao]]

No, I don't think so. How does it fail?

Comment 16

[Aruna]

Attachment: Bug-1408362.patch

Comment 17

[Dão Gottwald [:dao]]

Comment on attachment 8918811 [details] [diff] [review]
Bug-1408362.patch

Looks good. Thanks!

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/613d38c5f98c
Remove the tabbrowser-tabs class. r=dao

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/613d38c5f98c