1408613 - Fix visibility of PanelUI-panic-timeframe-icon

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P4)

Description

[magicp]

Attachment: PanelUI-panicView-in-overflow-menu.mp4

Steps to Reproduce:
1. Start Nightly
2. Add Forget button to Toolbar
3. Open Forget panel
4. Pin Forget button to Overflow Menu
5. Open Forget panel

Actual Results:
In step 3, #PanelUI-panic-timeframe-icon is invisible.
In step 5, #PanelUI-panic-timeframe-icon is visible while opening panel. (duplicate to small icon)

Expected Results:
In step 3, #PanelUI-panic-timeframe-icon is visible.
In step 5, #PanelUI-panic-timeframe-icon is hidden even if while opening panel.

Comment 1

[magicp]

Attachment: PanelUI-panicView-in-mainview.png

Comment 2

[magicp]

Attachment: PanelUI-panicView-in-overflow-menu.png

Comment 3

[magicp]

#PanelUI-panic-timeframe-icon and #PanelUI-panic-timeframe-icon-small visibility will be controled by #PanelUI-panicView current attribute and #PanelUI-panicView cui-widget-panelview class. But, current attribute doesn't work correctly after Bug 1401991. And also cui-widget-panelview class is not matched in photon panel. I think that #PanelUI-panic-timeframe-icon is always visible, and #PanelUI-panic-timeframe-icon-small is invisible in photon panel.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1408613 - stop trying to use a smaller image in the overflow panel which is wide enough,

Review commit: https://reviewboard.mozilla.org/r/197700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197700/

Comment 6

[:Gijs (he/him)]

Comment on attachment 8926452 [details]
Bug 1408613 - stop trying to use a smaller image in the overflow panel which is wide enough,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197700/diff/1-2/

Comment 7

[Mike de Boer [:mikedeboer]]

Comment on attachment 8926452 [details]
Bug 1408613 - stop trying to use a smaller image in the overflow panel which is wide enough,

https://reviewboard.mozilla.org/r/197700/#review202934

Looks great, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e2fd1290064
stop trying to use a smaller image in the overflow panel which is wide enough, r=mikedeboer

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7e2fd1290064

Comment 10

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 58.0a1 (2017-10-13) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171204150510
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0