1408645 - Long Press of Android System Back button does not show lists on Android 7.0 Nougat

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[jimimaseye]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170518000419

Steps to reproduce:

When I upgrade my Samsung A3 from (Marshmallow) 6 Android 7.0 Nougat, long pressing Android system 'back' button does not result in showing history of the tab after browsing a few web pages.  Now it only shows the main Firefox menu (the same as pressing the 3dots option).

This is identical to bug 1304688 which was filed and fixed against FF v50.


Actual results:

Long pressing Android system 'back' button just shows the main Firefox Menu.


Expected results:

The itemised history list should show for rapid selection (as it did under Marshmallow 6).

Comment 1

[Jan Henning [:JanH]]

(In reply to jimimaseye from comment #0)
> Now it only shows the main Firefox
> menu (the same as pressing the 3dots option).
> 
> This is identical to bug 1304688 which was filed and fixed against FF v50.

Not quite, bug 1304688 meant that long pressing wouldn't do anything at all. So it's not quite clear whether this is some generic Nougat-specific change, or just the manufacturer taking the OS update as a chance to change its button handling, but given that Samsung has been known to mess around with back button handling, this sounds more like bug 1328538.

Comment 2

[jimimaseye]

1328538 is not quite identical.  That bug clearly states that long pressing the back button *briefly shows the history list* before then being replaced by the menu:

"Hold back button -> history displays for less than half a second -> history is hidden gain and menu is displayed."

This is, in fact, what happened also on my device when it was at Android 6 (marshmallow).

My report is now that long pressing the back button simply goes straight to menu and no history is shown at all (not even momentarily).

It ,may be that Samsing have introduced a new response code to the back button on long pressing and that maybe under marshmallow it had a 2-stage response

ie, 
less than 0.5 seconds = action code 1 (which FF was coded to display the history)
more than 0.5 Second = action code 2  (which FF doesnt have a specific capture for and defaults to displaying Menu).

And maybe under Nougat 7.0 there is now no longer the first action.

In any case Im sure someone would be able to look in to the google code/api's for it determine this change and possible code to account for it accordingly?

Comment 3

[jimimaseye]

I have updated the apparent 'duplicate' thread with more information giving a clue to the problem/fix being within Firefox itself.:  https://bugzilla.mozilla.org/show_bug.cgi?id=1328538#c6

Comment 4

[Jan Henning [:JanH]]

I'm not sure in how far it's worth fixing this without also tackling bug 1328538 itself, but finding out what caused this behaviour change on our side might still be interesting. In any case this needs somebody with a phone that is actually affected.

Comment 5

[jimimaseye]

In Comment 2 is said:

"ie, 
less than 0.5 seconds = action code 1 (which FF was coded to display the history)
more than 0.5 Second = action code 2  (which FF doesnt have a specific capture for and defaults to displaying Menu).

And maybe under Nougat 7.0 there is now no longer the first action."


My update in bug 1328538 shows that another browser that is based on Firefox still operates the 2-action long press button on Android 7.  This, therefore shows that the idea of nougat not operating the 2-action longpress is not true and therefore, along with the fact a Firefox fork still operates as it did before, the failure to respond correctly is in the Firefox coding and rectifiable.

Comment 6

[jimimaseye]

Update and further proof:

The browser mentioned above (Adblock Browser) that is based on firefox has now also just updated based on the latest firefox.  And not it too has the same problem.  It has inherited the 'problem' with the common dem=nominator being the latest firefox versions.

Comment 7

[Sorina Florean [:sflorean]]

I was able to reproduce this with Samsung Galaxy S6 (Android 7.0) following the steps from description.

Regression range:
Last good build: 2016-09-30
First bad build: 2016-10-01

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=59db3b0781908d9e2145477ff8dc5a85729e25bf&tochange=87cd291d2db621da6b3eb1057027cc0725b6eb1d

Comment 8

[jimimaseye]

@Sorina You say in comment 7 that the dates relate to 2016.  Is that true?  (Is it not 2017?)

Comment 9

[Sorina Florean [:sflorean]]

(In reply to jimimaseye from comment #8)
> @Sorina You say in comment 7 that the dates relate to 2016.  Is that true? 
> (Is it not 2017?)

Hi, it's 2016. I tried two times because of the date, and for both regressions range the year was 2016.

Comment 10

[Jan Henning [:JanH]]

Hmm, that range contains bug 1304688, so some phones will be broken *without* that patch, while others (Samsung ?) are broken only *with* that patch? Great...
Although if this really affects only Samsung phones (and more or less all recent models of them at that), I guess we could try checking the manufacturer as well in addition to the OS version before running the workarounds from https://hg.mozilla.org/mozilla-central/rev/8d8964596de0.

Comment 11

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 13

[Stefan Deiac]

I can confirm this issue in the actual version of Nightly 64.0a1 (2018-10-21) and Release 63.0 with Samsung Galaxy Tab S3.

Comment 14

[csheany]

In fullscreen the intended behvior is performed although I'm not sure anything should happen.

Comment 15

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.