1408750 - allocateForDefinition: unused variable 'from'

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

In file included from /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/js/src/Unified_cpp_js_src19.cpp:20:
/data/jenkins/workspace/firefox-clang-last/js/src/jit/StupidAllocator.cpp:411:18: error: unused variable 'from' [-Werror,-Wunused-variable]
    CodePosition from;

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1408750 - allocateForDefinition: Remove unused variable 'from'

Review commit: https://reviewboard.mozilla.org/r/189474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189474/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

This is because clang improved its detection of unused variables: https://reviews.llvm.org/D38678

Comment 3

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8918648 [details]
Bug 1408750 - allocateForDefinition: Remove unused variable 'from'

https://reviewboard.mozilla.org/r/189474/#review194912

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5376560d4a73
allocateForDefinition: Remove unused variable 'from' r=nbp

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5376560d4a73