Closed
Bug 1408790
Opened 7 years ago
Closed 7 years ago
The non-selected elements with ids should be lightened to the same color as the non-selected classes
Categories
(DevTools :: Inspector, enhancement, P3)
DevTools
Inspector
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: hodginsl2, Assigned: hodginsl2)
Details
Attachments
(1 file)
No description provided.
Updated•7 years ago
|
Assignee: nobody → hodginsl2
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8918696 -
Flags: review?(gl)
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8918696 [details] Bug 1408790 - The non-selected elements with ids should be lightened to the same color as the non-selected classes https://reviewboard.mozilla.org/r/189506/#review199874 ::: devtools/client/themes/breadcrumbs.css:166 (Diff revision 1) > > .theme-light .breadcrumbs-widget-item { > color: var(--theme-body-color); > } > > .breadcrumbs-widget-item-id { So, we should just make this one rule since both items are gonna have the same color. I am also gonna just say we should hardcode it to var(--grey-40) for both light/dark theme. Maybe also do a check with Victoria afterwards. It seems to me that we were fine with the light grey in the id (--grey-40) in the light theme originally. The class is grey-30 in the dark theme, and having it as grey-40 also looks ok. Alternatively, we would have both the classes and id as grey-40 in the light theme and grey-30 in the dark theme. .breadcrumbs-widget-item-classes, .breadcrumbs-widget-item-id { color: var(--grey-40) }
Attachment #8918696 -
Flags: review?(gl)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8918696 [details] Bug 1408790 - The non-selected elements with ids should be lightened to the same color as the non-selected classes https://reviewboard.mozilla.org/r/189506/#review202704
Attachment #8918696 -
Flags: review?(gl) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ac9d12e5587f The non-selected elements with ids should be lightened to the same color as the non-selected classes r=gl
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ac9d12e5587f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•