1408791 - Investigate using react2angular instead of ngReact

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P3)

Description

[Ed Morley [:emorley]]

We currently use ngReact to embed React inside our Angular 1 app:
https://github.com/ngReact/ngReact

However the reademe of that project says:

> Note: For a more modern alternative to ngReact, we recommend react2angular, angular2react, and ngimport.

It looks like these alternatives both allow a more modern ES6 approach, plus will allow for an easier transition to more React and/or Angular 2.

See:
https://github.com/coatue-oss/react2angular
https://github.com/bcherny/ngimport

Comment 1

[Ed Morley [:emorley]]

Lets just focus on moving to React instead.

Comment 2

[Cameron Dawson [:camd]]

I changed my mind on this.  This package solves a couple issues I was hitting with ng-react.  :)

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3462

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8968655 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3462

You were right all along...  :)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4f2ee0c88b89b5fa9dcf0059308c4316d1df6e7c
Bug 1408791 - Move to using react2angular (#3462)

* Also fixes Bug 1451492 - Wording of Treeherder view for brand-new Try push is still sometimes the unfriendly version