1408957 - netwerk/protocol/device/ seems to be dead code

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Sylvestre Ledru [:Sylvestre]]

Schien said in https://bugzilla.mozilla.org/show_bug.cgi?id=1408751#c2 that the device directory is probably useless.
Reporting a bug to make sure it doesn't get lost.

The code coverage confirms that no test uses this code path:
https://codecov.io/gh/marco-c/gecko-dev/tree/master/netwerk/protocol/device

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1408957 - Remove netwerk/protocol/device/ (no longer used)

Review commit: https://reviewboard.mozilla.org/r/189662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189662/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

The try job is green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=310fb6aeb20a&selectedJob=137202427

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Dragana, who do you think should sign off on that? Thanks

Comment 4

[Dragana Damjanovic [:dragana]]

I do not see any use of 'moz-device' protocol in the code.

To be completely sure let's ask bz to confirm.

bz, do we use 'moz-device', i.e. nsDeviceChannel somewhere in dom? I see only GetUserMedia api.

I could review the code.

Comment 5

[Boris Zbarsky [:bzbarsky]]

This is the first time I've seen this code, so not sure how much use I'll be... but there seem to be no hits for either nsDeviceChannel or "moz-device:" anywhere.  And it's never been web-exposed.  So I think it's fine to remove.

Comment 6

[Dragana Damjanovic [:dragana]]

Comment on attachment 8918813 [details]
Bug 1408957 - Remove netwerk/protocol/device/ (no longer used)

https://reviewboard.mozilla.org/r/189662/#review195294

thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55172a4afa4a
Remove netwerk/protocol/device/ (no longer used) r=dragana

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/55172a4afa4a