Closed
Bug 1409116
Opened 7 years ago
Closed 7 years ago
Rename {WebAuthn,U2F}TransactionParent::Cancel message to Abort
Categories
(Core :: DOM: Device Interfaces, enhancement, P2)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
To fix the message flow in bug 1403818 I'd like to do some more cleanup first. It bugs me that the child sends a "Cancel" message to cancel a running transaction, yet we define a message with the same name "Cancel" sent by the parent when the transaction is aborted due to failure somewhere in the token manager.
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8918957 [details] Bug 1409116 - Rename {WebAuthn,U2F}TransactionParent::Cancel message to Abort J.C. Jones [:jcj] has approved the revision. https://phabricator.services.mozilla.com/D127#2844
Attachment #8918957 -
Flags: review+
Pushed by ttaubert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/25651852e886 Rename {WebAuthn,U2F}TransactionParent::Cancel message to Abort r=jcj
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/25651852e886
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•