Closed Bug 1409250 Opened 2 years ago Closed 2 years ago

[Form Autofill] Ensure autocomplete footer option can display long strings properly

Categories

(Toolkit :: Form Manager, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill:V2])

Attachments

(2 files)

As per discussion on Bug 1407530 (comment 7), it's hard to predict or specify how long the localized strings would be. We should make sure the strings can at least be displayed properly (ex. wrapped with correct margins) if they are longer than expected.

Visual spec: https://mozilla.invisionapp.com/share/MQ8J8K4CE#/screens/246435182
Assignee: nobody → scwwu
Status: NEW → ASSIGNED
Comment on attachment 8919344 [details]
Bug 1409250 - Add padding to Form Autofill dropdown footer button.

https://reviewboard.mozilla.org/r/190122/#review195762

Looks good. Thanks.
Attachment #8919344 - Flags: review?(lchang) → review+
Thanks! Checking it in.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/23ac0196ee84
Add padding to Form Autofill dropdown footer button. r=lchang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/23ac0196ee84
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.