Night mode needs some CSS magic

RESOLVED FIXED

Status

()

Firefox for iOS
General
P1
normal
RESOLVED FIXED
a month ago
22 days ago

People

(Reporter: SimonB, Assigned: justindarc)

Tracking

(Depends on: 4 bugs)

unspecified
Other
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios10.0, fxios-v10.0 affected, fxios-v11.0 affected)

Details

Attachments

(1 attachment)

(Reporter)

Description

a month ago
From user feedback: 

"When using night shift+night mode in browser some gray texts on white background are very hard to read, for example on site reddit.com".

Notes: 
- Some images that use darker shades of color are not very visible
- Google search field frame is not visible when using Night Mode - e.g. on google.com
(Assignee)

Updated

a month ago
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
tracking-fxios: ? → 10.0
Priority: -- → P1
Summary: Night mode needs some adjustments → Night mode needs some CSS magic
(Assignee)

Comment 1

a month ago
Created attachment 8919809 [details] [review]
GitHub Pull Request
Attachment #8919809 - Flags: review?(jhugman)
(Assignee)

Updated

a month ago
Attachment #8919809 - Flags: review?(jhugman) → review?(gkeeley)

Updated

a month ago
Blocks: 1410496

Comment 2

a month ago
Comment on attachment 8919809 [details] [review]
GitHub Pull Request

This is good to land now in Beta and get feedback, 
I found one issue that I filed as a follow up request: https://bugzilla.mozilla.org/show_bug.cgi?id=1410496
Attachment #8919809 - Flags: review?(gkeeley) → review+
(Assignee)

Comment 3

a month ago
Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/0ea24ae227c028ab3609da44fd431e84b3b7774c

Landed on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/9ff51ce3f49af28f8af7868e0a6d8152c23bca1d
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
(Reporter)

Updated

a month ago
Depends on: 1411566
(Reporter)

Updated

22 days ago
Depends on: 1413876
(Reporter)

Updated

22 days ago
Depends on: 1413885
(Reporter)

Updated

22 days ago
Depends on: 1413927
You need to log in before you can comment on or make changes to this bug.