Open Bug 1409550 Opened 7 years ago Updated 2 years ago

[lint] Fix AppCompatCustomView lint warnings

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect, P5)

Product:
Firefox Build System
Component:
Android Studio and Gradle Integration
Type:
defect

Tracking

(Not tracked)

People

(Reporter: nalexander, Unassigned)

References

Details

Newer build-tools added an AppCompatCustomView lint warning, which we fall afoul of: ../../../../../../../mobile/android/base/java/org/mozilla/gecko/widget/AllCapsTextView.java:11: This custom view should extend android.support.v7.widget.AppCompatTextView instead ... In order to support features such as tinting, the appcompat library will automatically load special appcompat replacements for the builtin widgets. However, this does not work for your own custom views. Instead of extending the android.widget classes directly, you should instead extend one of the delegate classes in android.support.v7.widget.AppCompat. To suppress this error, use the issue id "AppCompatCustomView" as explained in the Suppressing Warnings and Errors section. I'm going to ignore this in order to land new build-tools, but we should address it (or decide not to address it).
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195 Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5
Product: Firefox for Android → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.