1409579 - Error from redefinition of PATH_MAX in dom/system/OSFileConstants.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tom Ritter [:tjr] (OOTO until April)]

>  In file included from /builds/worker/workspace/build/src/obj-firefox/dom/system/Unified_cpp_dom_system0.cpp:2:0:
>  /builds/worker/workspace/build/src/dom/system/OSFileConstants.cpp:44:0: error: "PATH_MAX" redefined [-Werror]
>   #define PATH_MAX MAX_PATH
>  In file included from /builds/worker/workspace/build/src/gcc/lib/gcc/i686-w64-mingw32/6.4.0/include-fixed/limits.h:168:0,
>                   from /builds/worker/workspace/build/src/gcc/lib/gcc/i686-w64-mingw32/6.4.0/include-fixed/syslimits.h:7,
>                   from /builds/worker/workspace/build/src/gcc/lib/gcc/i686-w64-mingw32/6.4.0/include-fixed/limits.h:34,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/stdlib.h:10,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/c++/6.4.0/cstdlib:75,
>                   from /builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers/cstdlib:44,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/c++/6.4.0/stdlib.h:36,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/combaseapi.h:129,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/objbase.h:14,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/ole2.h:17,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/wtypes.h:12,
>                   from /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/accctrl.h:10,
>                   from /builds/worker/workspace/build/src/dom/system/OSFileConstants.cpp:42,
>                   from /builds/worker/workspace/build/src/obj-firefox/dom/system/Unified_cpp_dom_system0.cpp:2:
>  /builds/worker/workspace/build/src/gcc/i686-w64-mingw32/include/limits.h:20:0: note: this is the location of the previous definition
>   #define PATH_MAX 260
>  cc1plus: all warnings being treated as errors

Comment 1

[Tom Ritter [:tjr] (OOTO until April)]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=926eb2bb3bc758f1404b65ceae56899f6d5e1342

Comment 2

[Tom Ritter [:tjr] (OOTO until April)]

Attachment: Bug 1409579 Only define PATH_MAX if it is not already defined.

Review commit: https://reviewboard.mozilla.org/r/190374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190374/

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 8919532 [details]
Bug 1409579 Only define PATH_MAX if it is not already defined.

https://reviewboard.mozilla.org/r/190374/#review195834

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91c3ee492fde
Only define PATH_MAX if it is not already defined. r=jdm

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/91c3ee492fde

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 8919532 [details]
Bug 1409579 Only define PATH_MAX if it is not already defined.

https://reviewboard.mozilla.org/r/190374/#review197798

We have many definitions of PATH_MAX in the tree. It would be nice to find some way to combine them all, but that's beyond the scope of this bug.

Comment 7

[Nicholas Nethercote [inactive]]

Whoops, I meant to review bug 1411374. Sorry for the noise.