1409648 - gc -- processor rule_set strategies

Status: RESOLVED FIXED

(Socorro :: Processor, task)

Description

[Lonnen :lonnen]

This may be multiple commits, or this may become a tracker bug.

In practice, only two rule sets are used:

* apply_all_rules
* apply_until_action_succeeds

but other unused strategies remain in transform_rules:

* apply_until_action_fails
* apply_until_predicate_succeeds
* apply_until_predicate_fails

remove the unused strategies and associated tests.

Of the remaining strategies, apply_all_rules is used in most places. The following rule sets use the apply_until_action_succeeds strategy:

* support_classifiers 
* skunk_classifiers.

Most of the rules in these sets are disabled. Remove the disabled rules.

Determine if any of the remaining rules are no longer useful and remove them (support classifiers were created for an email-the-user subsystem that has not been shut down) (<1% of crashes have as support classifier) (00.0009% of Firefox crashes have a skunk classifier field)

Determine if we still need the apply_until_action_succeeds strategy, or if other optimizations will help us get to this state. The remaining rules are likely fine to use apply_all_rules instead.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4050: bug 1409648 - GC rule sets in source code

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/8c36b4fbe75ecf5df5bff26700ef8b8cd9a79cce
Merge pull request #4050 from mozilla-services/1409648-gc-rule_sets

bug 1409648 - GC rule sets in source code

Comment 3

[Lonnen :lonnen]

Landed and shipped. Strategies are gone, rules are managed in a single list, and rules are outside of configman's runtime loading system. Marking fixed.