140974 - JS constant folder over-eager with if (false) var x=42

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

See news://news.mozilla.org:119/[e-mail] -- patch coming up.

/be

Comment 1

[Brendan Eich [:brendan]]

ECMA correctness, would like to fix for 1.0.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: proposed fix

Looking for fast testing and review (worksforme, looks right).

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: deal with a for (var ...;;) ... counterexample (for-loop head is ternary)

Thanks to shaver for pointing this out!

/be

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 81536 [details] [diff] [review]
deal with a for (var ...;;) ... counterexample (for-loop head is ternary)

Cool. sr=shaver.

Comment 5

[Brendan Eich [:brendan]]

Not to worry, I've nuked that break; after return ...; in the PN_TERNARY case of
the latest patch.

/be

Comment 6

[Phil Schwartau]

The latest patch passes the JS testsuite on WinNT and Linux, in both
the debug and optimized shell. I got only the known test failures.

I will add Martin's test to the testsuite later today -

Comment 7

[Kenton Hanson (gone)]

Comment on attachment 81536 [details] [diff] [review]
deal with a for (var ...;;) ... counterexample (for-loop head is ternary)

r=khanson

Comment 8

[Brendan Eich [:brendan]]

Checked into trunk.  Going for 1.0 approval, it's an easy ECMA-purity fix.

/be

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 81536 [details] [diff] [review]
deal with a for (var ...;;) ... counterexample (for-loop head is ternary)

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 10

[Brendan Eich [:brendan]]

Fixed in trunk and branch.

/be

Comment 11

[Asa Dotzler [:asa]]

adding branch resolution keyword.

Comment 12

[Phil Schwartau]

Testcase added to JS testsuite:

            mozilla/js/tests/js1_5/Regress/regress-140974.js

Sections 4 through 6 of this test failed before the fix.
The test now passes on the trunk and on the 1.0.0 branch.

Marking Verified FIXED and adding verified1.0.0 keyword -

Comment 13

[Phil Schwartau]

Typo:        'Sections 4 through 6 of this test failed before the fix'
should be:   'Sections 3 through 6 of this test failed before the fix'