1409803 - Whitespace handling for bookmark keywords in full-page edit dialogue

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, enhancement)

Description

[Jan Henning [:JanH]]

The old Edit Bookmark dialogue has some logic that
- strips any leading/trailing whitespace
- disables the save button if a keyword with spaces mid-string is entered

as keywords with spaces don't work. If we're adding keyword editing to the new dialogue, too (bug 1405215), I need to port that logic as well.

Comment 1

[Alessio "Spinus" Moscatello]

I think that if you port this logic, it'll solve the problem I've reported in bug 1409758...currently the save button is disabled even if leading/trailing (not middle) white space is present, but it shouldn't since the logic should automatically remove leading/trailing white space, I'm right?

BR,
Alessio

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1409803 - Copy logic to prevent spaces in keywords to new Edit Bookmark dialogue.

Review commit: https://reviewboard.mozilla.org/r/191282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191282/

Comment 3

[Jan Henning [:JanH]]

(In reply to Alessio "Spinus" Moscatello from comment #1)
> ...currently the save button is disabled even if
> leading/trailing (not middle) white space is present, but it shouldn't since
> the logic should automatically remove leading/trailing white space, I'm
> right?

We already do that in old dialogue that's used for Beta and Release and the new one won't be any different once this bug and bug 1405215 are resolved, so I'm not quite sure what you're referring to?

Comment 4

[Alessio "Spinus" Moscatello]

I've just took a look at the patch, it seems that is precisely what I was looking for :) I'll test it once it'll be integrated in official release :)

Thanks

BR,
Alessio

Comment 5

[Jing-wei Wu [:jwu]]

Comment on attachment 8920289 [details]
Bug 1409803 - Copy logic to prevent spaces in keywords to new Edit Bookmark dialogue.

https://reviewboard.mozilla.org/r/191282/#review197362

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 41fdaf0948ab -d 44455b744ee8: rebasing 431124:41fdaf0948ab "Bug 1409803 - Copy logic to prevent spaces in keywords to new Edit Bookmark dialogue. r=jwu" (tip)
merging mobile/android/base/java/org/mozilla/gecko/bookmarks/BookmarkEditFragment.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/bookmarks/BookmarkEditFragment.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Jan Henning [:JanH]]

Rebase conflict with bug 1382049.

Comment 8

[Jan Henning [:JanH]]

Comment on attachment 8920289 [details]
Bug 1409803 - Copy logic to prevent spaces in keywords to new Edit Bookmark dialogue.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191282/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41625f3d3a6a
Copy logic to prevent spaces in keywords to new Edit Bookmark dialogue. r=jwu

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/41625f3d3a6a