1405215 - Keyword field missing in new Edit Bookmark dialog

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[janghou]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36 OPR/48.0.2685.26 (Edition beta)

Steps to reproduce:

Start Firefox Nightly
- Click Menu
- Click Bookmarks
- Longclick any bookmark -> Edit

I want to edit a bookmark to make it accessible from the location bar by typing a keyword and a searchterm   
Eg
keyword: ciu 
location:  http://caniuse.com/#search=%s

This is actually one of the hidden gems of Firefox Android that really help daily productivity


Actual results:

Dialog shows
- name
- Location
- Parent Folder


Expected results:

Dialog shows
- name
- Location
- Keyword
- Parent Folder

So I can't enter a keyword anymore, old bookmarks still work, so it's a dialog thing.
This works in Firefox Android 56 and Firefox Android Beta 57, just not in Nightly 58

Comment 1

[Jan Henning [:JanH]]

As far as I'm aware, the new Edit Bookmark dialogue is still Nightly-only for the time being.

Comment 2

[Sorina Florean [:sflorean]]

Keyword field is not available in Nightly with new Bookmarks changes.

Comment 3

[Tori Chen [:tori]]

Per discussion with the team, after implementing folder management feature, keyword will not be supported. It's more consistent with desktop bookmark and general user habits.

Comment 4

[janghou]

I don't get this. IMHO this is quite a powerful an valuable feature that should not be dumped, even if most users are unaware of it. 

I have lots of functionality that depends on it, actually it's a killer feature for handling REST-API's (home automation) in your mobile browser, and for sites you can't create custom search-engines for, like CanIUse.com.

Doesn't feel consistent to me, when they suddenly stop working with a new Firefox update.
 
firefox for android supports keyword
firefox for android beta supports keyword
firefox for desktop supports keyword 
firefox developer for desktop supports keyword (hidden away in properties)

So every version, except Firefox Android Nightly 58, supports keyword since years. 
It's consistent to keep it implemented! 

And what's the problem, it's just one input field.

Please reconsider your plans.

Comment 5

[Richard Newman [:rnewman]]

(In reply to Tori Chen [:tori] from comment #3)
> Per discussion with the team, after implementing folder management feature,
> keyword will not be supported. It's more consistent with desktop bookmark
> and general user habits.

FWIW, desktop is exactly where keyword management is already supported, and Fennec stores and uses keywords added by desktop.

Keywords are orthogonal to folders, both in the data model and in desktop Firefox.

Comment 6

[Jan Henning [:JanH]]

Attachment: Bug 1405215 - Part 1 - Allow editing keyword in new Edit Bookmark dialogue.

Review commit: https://reviewboard.mozilla.org/r/187316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187316/

Comment 7

[Jan Henning [:JanH]]

As per Antlam's original suggestion somewhere in bug 1232439, this adds the "keyword" field at the bottom, below the folder chooser.

Comment 8

[Jing-wei Wu [:jwu]]

Comment on attachment 8916074 [details]
Bug 1405215 - Part 1 - Allow editing keyword in new Edit Bookmark dialogue.

https://reviewboard.mozilla.org/r/187316/#review192590

Comment 9

[Jing-wei Wu [:jwu]]

The patch is fine but I am not sure we have reached a consensus to move the 'keyword' field back. Perhaps we should ask for Joe's opinion from product perspective.

Comment 10

[Jan Henning [:JanH]]

(In reply to Richard Newman [:rnewman] from comment #5)
> (In reply to Tori Chen [:tori] from comment #3)
> > Per discussion with the team, after implementing folder management feature,
> > keyword will not be supported. It's more consistent with desktop bookmark
> > and general user habits.
> 
> FWIW, desktop is exactly where keyword management is already supported, and
> Fennec stores and uses keywords added by desktop.
> 
> Keywords are orthogonal to folders, both in the data model and in desktop
> Firefox.

Keywords are indeed a bit hidden on Desktop, as they're only visible in the Bookmarks library *after* pressing the "More" button, but then on the other hand Desktop exposes Tags by default, which to my mind seems like a similarly obscure feature.

Since we don't support Tags at all, why we shouldn't show Keywords instead and besides, the goal of folder management was to allow users managing their folders *without* having to use Sync, wasn't it? So why should we regress Keyword support now and force users to use Sync for editing their keywords instead?

Comment 11

[Tori Chen [:tori]]

From UX perspective I am fine with putting keyword field back. Could you please advise, Joe?

Comment 12

[Jan Henning [:JanH]]

(In reply to Jan Henning [:JanH] from comment #7)
> As per Antlam's original suggestion somewhere in bug 1232439, this adds the
> "keyword" field at the bottom, below the folder chooser.

After looking a bit more closely, I'd rather swap the locations of the Keyword and Parent Folder field after all and put the Parent Folder as last entry:
Some keyboards (e.g. Gboard or Swiftkey) take up so much screen space that putting the cursor into the Keyword field at its currently proposed location pushes the action bar with the "Save" button out of view. Since apparently you *cannot* scroll while the keyboard is up, this means you have to dismiss the keyboard again before being able to hit "Save" after editing the keyword.

Comment 13

[Jan Henning [:JanH]]

Or else make the tool bar sticky, I suppose...

Comment 14

[Jan Henning [:JanH]]

Attachment: Bug 1405215 - Part 2 - Make new Edit Bookmark dialogue scrollable.

Otherwise
- the keyboard pushes the toolbar with the "Save" button out of view when entering text into the last input field
- the last input field isn't even accessible in landscape orientation.

Review commit: https://reviewboard.mozilla.org/r/191284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191284/

Comment 15

[Jan Henning [:JanH]]

Comment on attachment 8916074 [details]
Bug 1405215 - Part 1 - Allow editing keyword in new Edit Bookmark dialogue.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187316/diff/1-2/

Comment 16

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8920276 [details]
Bug 1405215 - Part 2 - Make new Edit Bookmark dialogue scrollable.

https://reviewboard.mozilla.org/r/191284/#review197164

Please ni UX after it's landed. Thanks a lot!

Comment 17

[Jing-wei Wu [:jwu]]

Comment on attachment 8920276 [details]
Bug 1405215 - Part 2 - Make new Edit Bookmark dialogue scrollable.

https://reviewboard.mozilla.org/r/191284/#review197364

Comment 18

[Jan Henning [:JanH]]

(In reply to Nevin Chen [:nechen] from comment #16)
> Please ni UX after it's landed. Thanks a lot!

Will do, but I take it I should still be waiting for a comment from Joe first?

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5614bd22556c
Part 1 - Allow editing keyword in new Edit Bookmark dialogue. r=jwu
https://hg.mozilla.org/integration/autoland/rev/44455b744ee8
Part 2 - Make new Edit Bookmark dialogue scrollable. r=jwu,nechen

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5614bd22556c
https://hg.mozilla.org/mozilla-central/rev/44455b744ee8

Comment 21

[Jan Henning [:JanH]]

(In reply to Nevin Chen [:nechen] from comment #16)
> Comment on attachment 8920276 [details]
> Bug 1405215 - Part 2 - Make new Edit Bookmark dialogue scrollable.
> 
> https://reviewboard.mozilla.org/r/191284/#review197164
> 
> Please ni UX after it's landed. Thanks a lot!

^^

Comment 22

[Carol Huang [:Carol]]

It looks good to me on Nightly. :)
Thanks!

Comment 23

[u549602]

Verified as fixed on the latest Beta (58.0b3/build 4) and the latest Nightly (59.0a1 / 2017-11-14)
This issue was tested on a Pixel C (Android 8.0)

Comment 24

[Marco Bonardo [:mak]]

FYI, Desktop will likely remove the keyword field and go for bug 648398 instead. As a consequence, I wontfixed bug 1421577 as well as all the previous bugs that required the keyword field to be added to the star panel.
Keywords are an half done and low usage search feature that doesn't really pertain to bookmarks.

Comment 25

[Jan Henning [:JanH]]

Hm, bug 1106626 and bug 444284 would cover my major concerns about that move, but the prospects of seeing all that properly implemented for Fennec as well before the old functionality is lost make me somewhat nervous - and on top of that Fennec currently doesn't even support keywords for search engines and therefore also hidden search engines that are accessible via keyword only.

Plus bug 444284 talks about potentially not syncing between mobile and desktop, which would be another step backwards compared to today.

But thanks for the heads-up.