Closed
Bug 1409892
Opened 7 years ago
Closed 7 years ago
Migrate Job info left pane to ReactJS
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P3)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: sclements, Mentored)
References
Details
Attachments
(2 files)
When a job is selected, a panel at the bottom of the screen opens up showing some information about that job. This bug is about what shows in the left of that panel. The tabbed area on the right is separate. It is currently written in AngularJS, but we are in the process of migrating from Angular to React.
An example of a React component that lives inside our AngularJS base is:
* https://github.com/mozilla/treeherder/blob/e8fb2cefb5e86738419b02d5fa00795ea46fa107/ui/js/reactrevisions.jsx#L3
The files that apply to this feature that will need to be migrated include:
https://github.com/mozilla/treeherder/blob/a5f0fadf29ec605f96681d3df9897faf189915ab/ui/plugins/pluginpanel.html#L140-L254
https://github.com/mozilla/treeherder/blob/30f06d36bc79c2dbda7c311a91e4595b386f3e1e/ui/plugins/controller.js#L12
So a part of the challenge will be to get data out of AngularJS and into your React component. This could be that you fetch this in a separate Ajax call, but would be better if it could be passed to the React component from Angular since Angular is doing a set of concurrent ajax calls for the data already.
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → sclements313
Mentor: cdawson
Status: NEW → ASSIGNED
Priority: -- → P3
Reporter | ||
Updated•7 years ago
|
Blocks: treeherder-react
Updated•7 years ago
|
Component: Treeherder → Treeherder: Frontend
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8925225 -
Flags: review?(cdawson)
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 8925225 [details] [review]
[treeherder] sarah-clements:job_details_react > mozilla:master
Clearing the review request for now till you wrap things up. Looking great so far!
Attachment #8925225 -
Flags: review?(cdawson)
Assignee | ||
Updated•7 years ago
|
Attachment #8925225 -
Flags: review?(cdawson)
Reporter | ||
Comment 4•7 years ago
|
||
Comment on attachment 8925225 [details] [review]
[treeherder] sarah-clements:job_details_react > mozilla:master
OK, I've done a pass on this and things are looking really good. Just a few minor changes I've noted. Please reassign to me when you've done your updates. Thanks!
Attachment #8925225 -
Flags: review?(cdawson) → review-
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8925225 [details] [review]
[treeherder] sarah-clements:job_details_react > mozilla:master
Thanks for the feedback! I've made a few minor bug fixes in addition to what you've suggested.
Attachment #8925225 -
Flags: review- → review?(cdawson)
Reporter | ||
Comment 6•7 years ago
|
||
Comment on attachment 8925225 [details] [review]
[treeherder] sarah-clements:job_details_react > mozilla:master
This looks great! Nice work! :)
Attachment #8925225 -
Flags: review?(cdawson) → review+
Comment 7•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/81a77135715c12692e7d301210ba1e216fe9c263
Bug 1409892 - Create components to migrate job info left pane to React (#2913)
Reporter | ||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•