1410114 - The "Bookmarks Toolbar" option from the customize panel is offset in full screen mode

Status: NEW

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Toolbars.png

[Affected versions]:
Firefox 57.0b9 (BuildId:20171016185129)
Firefox 58.0a1 (BuildId:20171019100107)

[Affected platforms]:
-macOS 10.11.6 
-macOS 10.12.1

[Unaffected platforms]:
- Windows 10 64bit
- Ubuntu 16.04 64bit

[Steps to reproduce]:
1. Launch Firefox.
2. Enter Full Screen mode.
3. Open the "Hamburger" menu.
4. Click the "Customize" button.
5. Click the "Toolbars" button (found in the customize panel).

[Expected result]:
The "Bookmarks Toolbar" option is displayed close to the "Toolbars" button.

[Actual result]:
"Bookmarks Toolbar" option is displayed far from the "Toolbars" button.

[Regression range]:
This is a regression:
Last good revision: bbd783f7fd35e57b31e77d884031a43a1bb723f6
First bad revision: 328777d9661982453f572b4bb059beb1ad6dc544

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bbd783f7fd35e57b31e77d884031a43a1bb723f6&tochange=328777d9661982453f572b4bb059beb1ad6dc544

It seems that Bug 1354123 may have introduced this regression.

[Additional notes]:
For more information regarding this issue please observe the attached screenshot.

Please note that I managed to reproduce this issue only on macOS that has the following browser size:

Browser window width: 1920.
Browser window height: 1012.

I didn't managed to reproduce this issue using a macOS with the Browser windows height of 1008.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Gijs! 

It seems that the patch for Bug 1354123 may have introduced this regression.

Could you please have a look into this?

Thanks!

Comment 2

[Mike de Boer [:mikedeboer]]

For the life of me, I can't reproduce this at all. I'll install High Sierra tomorrow and dive a bit deeper tomorrow.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Marcia, are you able to reproduce this?

Comment 4

[Marcia Knous [:marcia]]

Attachment: Screenshot from 10.12.6 using Firefox 57 Beta 10

Screenshot of issue using a different Macbook, running Beta 10. This looks worse than the screenshot Emil posted.

Comment 5

[Marcia Knous [:marcia]]

I haven't been able to reproduce this on my 10.13 machine using the same build.

Comment 6

[Emil Ghitta, QA [:emilghitta]]

Hmm...the behavior encountered by Marcia in comment 4 is found in Bug 1410056.

Comment 7

[Mike de Boer [:mikedeboer]]

Can't reproduce, not actively working on this. Since this bug and bug 1410056 are so similar, I've asked Markus there to take a look when he has time.

Comment 8

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals