1410056 - Toolbar dropdown is not visible in full screen mode on Mac OS X

Status: NEW

(Core :: Widget: Cocoa, defect, P4)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

[Affected versions]:
Firefox 57.0b9
Firefox Nightly 58.0a1 (2017.10.19)

[Unaffected versions]:
Firefox 56.0.1 

[Affected platforms]:
Mac 10.13.1.

[Steps to reproduce]:
1.Launch Firefox.
2.Enter Full Screen mode
3.Open the hamburger menu and navigate to customize, press the "Toolbars" button from bottom of page near by "Themes" and "Density" buttons.

[Expected result]:
Dropdown menu appears and it conatins "Bookmarks Toolbar" menu item.

[Actual result]:
The dropdown menu is empty, only with an arrow, if you hover on this arrow is flickering.

[Regression range]:
This seems to be a regression:
Last good revision: 2017.06.30
First bad revision: 2017.07.01

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d9a144b7b6d994fc9a497c53b13f51a2a654d85e&tochange=587daa4bdc4b40b7053f4ca3b74723ca747f3b52

[Additional Information]:
Please observe the attached screenshots for more details: 
Normal screen mode: https://imgur.com/0kKHRjN
Full screen mode: https://imgur.com/7rhouq4

Comment 1

[Mike de Boer [:mikedeboer]]

I'm having trouble reproducing this issue locally on OSX 10.12.6. Is this reproducible only on High Sierra?
What's the contents of your Browser Console, i.e. are there any JavaScript error in there?

Comment 2

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

This issue is reproducible on Mac OS X 10.12.6, only if you start with new profile and Full Screen mode, click on Hamburger menu/Customize/Toolbars then you observe the actual results : The dropdown menu is empty, only with an arrow, if you hover on this arrow is flickering.

Comment 3

[Jim Mathies [:jimm]]

This looks like it slipped through the radar, can you take a look?

Comment 4

[Mike de Boer [:mikedeboer]]

This has not slipped under the radar, Jim, it's simply that none of us is able to reproduce this.

Comment 5

[Justin Dolske [:Dolske]]

I also can't reproduce this (macOS 10.12.6), nor do I see anything in the comment 0 regression range that looks obvious.

This is basically inactionable without a someone being able to reproduce it, or someone who can narrowing this down to a specific regressing bug.

P4 feels like the right priority still, given that this is presumably reproducible only under narrow circumstances and has minor impact.

Comment 6

[Marcia Knous [:marcia]]

I can reproduce this issue on an older Mac (Macbook Pro 13 inch, early 2011) running 10.12.6, running 57 Beta 11.

I cannot reproduce this issue on a newer Mac running 10.13.1 (17B46a).

Comment 7

[Mike de Boer [:mikedeboer]]

Markus, sorry to bother you with this, but do you have an older mac/ mac with 10.12.6 on it and can you reproduce this issue on it?
If so, can you take a look at this? Since it's very specifically tied to a specific Mac OS version range, I'm pretty sure this is a Cocoa Widget bug.

Comment 8

[Markus Stange [:mstange]]

I can reproduce this on 10.12.6 with my Dock set to always visible ("hiding off"). The lower edge of the tiny menu is where the upper edge of my Dock would be. I agree that this is a Cocoa widget bug.

Stephen, maybe we need to try another window level for this menu?

Comment 9

[Stephen A Pohl [:spohl]]

This reproduces on 10.12.6 and 10.13.1 for me. It's easiest to reproduce the problem when the window isn't fullscreen:
1. Drag the window down behind the Dock into a position where the dropdown will intersect with the top edge of the Dock.
2. Open the toolbar dropdown.
3. If the issue doesn't reproduce, readjust the position of the browser window until the dropdown intersects with the top edge of the Dock.

In order to reproduce in fullscreen, the Dock's size needs to be adjusted to be just at the right height to intersect with the toolbar dropdown.

I've tried setting the window level to NSDockWindowLevel, and even NSDockWindowLevel+1 with no success. It seems strange that this would occur in fullscreen when the Dock is clearly hidden, but I haven't been able to find a way to work around this so far.

Comment 10

[:Gijs (he/him)]

Doesn't seem important to track this as part of photon cleanup, and clearly wontfix for 57.

Comment 11

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

The issue is still reproducible on macOS 10.12 and macOS M1 mini 11.2.2 with Fireofox 88.0a1 (20210303215027). I can reproduce the issue using full-screen-api.macos-native-full-screen on false and on true as well. Also, this is not only a full-screen bug, like stated in comment 9. If firefox is placed with the bottom part under the dock, the toolbar drop-down is not displayed as expected.