1410139 - Failure in XMLHttpRequest/open-url-encoding.htm

Status: RESOLVED DUPLICATE of bug 1460233

(Core :: DOM: Networking, enhancement, P3)

Description

[Thomas Wisniewski]

This bug is a follow-up to bug 1405696, where we change XMLHttpRequest to pass the document charset into NS_NewURI to match a spec change.

This change causes us to behave differently to other engines on the second web platform test in XMLHttpRequest/open-url-encoding.htm. (Note that until bug 1405696 lands, we will appear to be passing this test).

We emit "&%2365533;" for the "lone surrogate" test while Blink/WebKit emit "%26%2355357%3B" and Edge emits "?". It's unclear to me whether we should be escaping the ampersand and semicolon as Blink/WebKit do.

Comment 1

[Thomas Wisniewski]

Per bug 1405696 comment 33, it turns out that Firefox is doing the right thing after all for this test, so I'm closing this as invalid (and will ensure the correct expectation is set for this test when I check in the patch in that bug).

Comment 2

[Thomas Wisniewski [:twisniewski]]

In the end, in bug 140569 we decided to consider this "lone surrogate" test failure in its own bug, so I'm reopening this.

annevk, emk, did you have insight on what we need to do here?

Comment 3

[Masatoshi Kimura [:emk]]

What was changed since bug 1405696 comment 33?

Comment 4

[Thomas Wisniewski [:twisniewski]]

Nothing; I didn't end up changing the test-case or Firefox's behavior, so we're still failing the WPT as it is (as is everyone except Chrome). Based on that and the comment you highlighted, I'm guessing that means the test should be altered to expect our behavior, but I figured it would be best to get a second opinion before doing so.

Comment 5

[Thomas Wisniewski [:twisniewski]]

I should also note that we're not failing the same way that Webkit and Edge are, according to wpt.fyi: https://wpt.fyi/results/xhr/open-url-encoding.htm

Comment 6

[Anne (:annevk)]

This will be fixed once bug 1460233 is fixed. (That will also fix a large number of Encoding Standard tests, so if someone can take that on it'd be good for our wpt test score.)