Closed
Bug 1410233
Opened 7 years ago
Closed 7 years ago
Placeholder text should not be italicized on Windows 8 and later
Categories
(Toolkit :: Themes, enhancement, P1)
Tracking
()
VERIFIED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | verified |
People
(Reporter: abenson, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(1 file)
Italicizing placeholder text in Windows was a pattern in Windows XP / 7 but we should be using regular text for placeholder text to match other native Windows experiences (1). I've found italicized placeholder text being used in the following input fields: - URL Bar / Awesombar - Search Bar - Sidebar search fields - Preferences input fields with placeholder text (1) https://msdn.microsoft.com/en-us/library/windows/apps/hh750315.aspx
Updated•7 years ago
|
Whiteboard: [photon-visual] → [photon-visual][triage]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dao+bmo
Blocks: photon-visual
Status: NEW → ASSIGNED
Component: Theme → Themes
Priority: -- → P1
Product: Firefox → Toolkit
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8920552 [details] Bug 1410233 - Restrict placeholder italicization to Windows 7. https://reviewboard.mozilla.org/r/191558/#review197140 Looks good cheers
Attachment #8920552 -
Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/100f13a8b091 Restrict placeholder italicization to Windows 7. r=daleharvey
![]() |
||
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/100f13a8b091
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee | ||
Updated•7 years ago
|
Flags: qe-verify+
OS: Unspecified → Windows
Summary: Placeholder text should not be italicized on Windows → Placeholder text should not be italicized on Windows 8 and later
Comment 5•7 years ago
|
||
Hi, here we need to verify if the text from url bar is not italic or the text that we will write in the url bar doesn't have the italic style? I tested the latest Nightly 58.0a1(2017-11-02) on Windows 7 and the text from the url bar is italic, please see here https://imgur.com/2Y4eP4T Thanks
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to ovidiu boca[:Ovidiu] from comment #5) > Hi, here we need to verify if the text from url bar is not italic or the > text that we will write in the url bar doesn't have the italic style? > > I tested the latest Nightly 58.0a1(2017-11-02) on Windows 7 and the text > from the url bar is italic, please see here https://imgur.com/2Y4eP4T > > Thanks Yes, this bug is about that placeholder text shown in your screenshot.
Flags: needinfo?(dao+bmo)
Comment 7•7 years ago
|
||
https://imgur.com/2Y4eP4T here you can see the actual result on Windows 7 tested on FF Nightly 58.0a1(2017-11-02), from what I understood the placeholder text should be regular.
Comment 9•7 years ago
|
||
Tested on Windows 8 and Windows 10 with FF Nightly 58.0a1(2017-11-02) and I can confirm the fix.
You need to log in
before you can comment on or make changes to this bug.
Description
•