1410233 - Placeholder text should not be italicized on Windows 8 and later

Status: VERIFIED FIXED

(Toolkit :: Themes, enhancement, P1)

Description

[Aaron Benson]

Italicizing placeholder text in Windows was a pattern in Windows XP / 7 but we should be using regular text for placeholder text to match other native Windows experiences (1). 

I've found italicized placeholder text being used in the following input fields:

- URL Bar / Awesombar
- Search Bar
- Sidebar search fields
- Preferences input fields with placeholder text


(1) https://msdn.microsoft.com/en-us/library/windows/apps/hh750315.aspx

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1410233 - Restrict placeholder italicization to Windows 7.

Review commit: https://reviewboard.mozilla.org/r/191558/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191558/

Comment 2

[Dale Harvey (:daleharvey)]

Comment on attachment 8920552 [details]
Bug 1410233 - Restrict placeholder italicization to Windows 7.

https://reviewboard.mozilla.org/r/191558/#review197140

Looks good cheers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/100f13a8b091
Restrict placeholder italicization to Windows 7. r=daleharvey

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/100f13a8b091

Comment 5

[ovidiu boca[:Ovidiu]]

Hi, here we need to verify if the text from url bar is not italic or the text that we will write in the url bar doesn't have the italic style?

I tested the latest Nightly 58.0a1(2017-11-02) on Windows 7 and the text from the url bar is italic, please see here https://imgur.com/2Y4eP4T

Thanks

Comment 6

[Dão Gottwald [:dao]]

(In reply to ovidiu boca[:Ovidiu] from comment #5)
> Hi, here we need to verify if the text from url bar is not italic or the
> text that we will write in the url bar doesn't have the italic style?
> 
> I tested the latest Nightly 58.0a1(2017-11-02) on Windows 7 and the text
> from the url bar is italic, please see here https://imgur.com/2Y4eP4T
> 
> Thanks

Yes, this bug is about that placeholder text shown in your screenshot.

Comment 7

[ovidiu boca[:Ovidiu]]

https://imgur.com/2Y4eP4T here you can see the actual result on Windows 7 tested on FF Nightly 58.0a1(2017-11-02), from what I understood the placeholder text should be regular.

Comment 8

[Dão Gottwald [:dao]]

No, this bug is about Windows 8 and later.

Comment 9

[ovidiu boca[:Ovidiu]]

Tested on Windows 8 and Windows 10 with FF Nightly 58.0a1(2017-11-02) and I can confirm the fix.