Closed Bug 1410233 Opened 2 years ago Closed 2 years ago

Placeholder text should not be italicized on Windows 8 and later

Categories

(Toolkit :: Themes, enhancement, P1)

58 Branch
Unspecified
Windows
enhancement

Tracking

()

VERIFIED FIXED
mozilla58
Tracking Status
firefox58 --- verified

People

(Reporter: abenson, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 file)

Italicizing placeholder text in Windows was a pattern in Windows XP / 7 but we should be using regular text for placeholder text to match other native Windows experiences (1). 

I've found italicized placeholder text being used in the following input fields:

- URL Bar / Awesombar
- Search Bar
- Sidebar search fields
- Preferences input fields with placeholder text


(1) https://msdn.microsoft.com/en-us/library/windows/apps/hh750315.aspx
Whiteboard: [photon-visual] → [photon-visual][triage]
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Component: Theme → Themes
Priority: -- → P1
Product: Firefox → Toolkit
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Comment on attachment 8920552 [details]
Bug 1410233 - Restrict placeholder italicization to Windows 7.

https://reviewboard.mozilla.org/r/191558/#review197140

Looks good cheers
Attachment #8920552 - Flags: review?(dharvey) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/100f13a8b091
Restrict placeholder italicization to Windows 7. r=daleharvey
https://hg.mozilla.org/mozilla-central/rev/100f13a8b091
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Flags: qe-verify+
OS: Unspecified → Windows
Summary: Placeholder text should not be italicized on Windows → Placeholder text should not be italicized on Windows 8 and later
Depends on: 1411460
Hi, here we need to verify if the text from url bar is not italic or the text that we will write in the url bar doesn't have the italic style?

I tested the latest Nightly 58.0a1(2017-11-02) on Windows 7 and the text from the url bar is italic, please see here https://imgur.com/2Y4eP4T

Thanks
Flags: needinfo?(dao+bmo)
(In reply to ovidiu boca[:Ovidiu] from comment #5)
> Hi, here we need to verify if the text from url bar is not italic or the
> text that we will write in the url bar doesn't have the italic style?
> 
> I tested the latest Nightly 58.0a1(2017-11-02) on Windows 7 and the text
> from the url bar is italic, please see here https://imgur.com/2Y4eP4T
> 
> Thanks

Yes, this bug is about that placeholder text shown in your screenshot.
Flags: needinfo?(dao+bmo)
https://imgur.com/2Y4eP4T here you can see the actual result on Windows 7 tested on FF Nightly 58.0a1(2017-11-02), from what I understood the placeholder text should be regular.
No, this bug is about Windows 8 and later.
Tested on Windows 8 and Windows 10 with FF Nightly 58.0a1(2017-11-02) and I can confirm the fix.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.