1411460 - stylo: Investigate why editor/reftests/xul/empty-1.xul fails on Windows

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

See https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e036a5afa8548d84ca07871f2b3c411d8dac8ef6&filter-searchStr=Windows%2010%20x64%20debug%20Reftest%20Reftest%20R(R2)&selectedJob=139299078

It was disabled on Stylo before bug 1408811, and it didn't fail in try push there [1], so it could be some regression in the mean time.


[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3beb02e6883dfef017d4d80dbddf18b386ffc92

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

OK, I think this was regressed by bug 1410233, which changes the corresponding behavior on Windows 10 in theme style sheet but not the testcase. It is not clear to me why that didn't break the test, though. It seems to me this test is broken regardless of whether stylo is enabled.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Hmmm, but making the stylesheet of reference match textbox.css doesn't fix the test :/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

(In reply to Xidorn Quan [:xidorn] UTC+10 (less responsive Nov 5 ~ Dec 16) from comment #2)
> Hmmm, but making the stylesheet of reference match textbox.css doesn't fix
> the test :/

So this is because reftest doesn't rebuild reftest.jar, and thus the input.css file used in those tests are not updated.

reftest.jar is not updated even with `mach build faster` :/

Anyway, having the media condition in input.css match that in textbox.css makes this test pass for me locally. I'll do a try push to confirm.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=06ebd772667069d2c4b125834da6557b6af46d2e

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1411460 - Sync input.css with style in textbox.css.

Review commit: https://reviewboard.mozilla.org/r/195694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195694/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8924412 [details]
Bug 1411460 - Sync input.css with style in textbox.css.

https://reviewboard.mozilla.org/r/195694/#review200892

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be60c2b625ae
Sync input.css with style in textbox.css. r=dao

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/be60c2b625ae