Closed Bug 1411460 Opened 2 years ago Closed 2 years ago
stylo: Investigate why editor/reftests/xul/empty-1
.xul fails on Windows
59 bytes, text/x-review-board-request
See https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e036a5afa8548d84ca07871f2b3c411d8dac8ef6&filter-searchStr=Windows%2010%20x64%20debug%20Reftest%20Reftest%20R(R2)&selectedJob=139299078 It was disabled on Stylo before bug 1408811, and it didn't fail in try push there , so it could be some regression in the mean time.  https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3beb02e6883dfef017d4d80dbddf18b386ffc92
OK, I think this was regressed by bug 1410233, which changes the corresponding behavior on Windows 10 in theme style sheet but not the testcase. It is not clear to me why that didn't break the test, though. It seems to me this test is broken regardless of whether stylo is enabled.
Hmmm, but making the stylesheet of reference match textbox.css doesn't fix the test :/
(In reply to Xidorn Quan [:xidorn] UTC+10 (less responsive Nov 5 ~ Dec 16) from comment #2) > Hmmm, but making the stylesheet of reference match textbox.css doesn't fix > the test :/ So this is because reftest doesn't rebuild reftest.jar, and thus the input.css file used in those tests are not updated. reftest.jar is not updated even with `mach build faster` :/ Anyway, having the media condition in input.css match that in textbox.css makes this test pass for me locally. I'll do a try push to confirm.
Comment on attachment 8924412 [details] Bug 1411460 - Sync input.css with style in textbox.css. https://reviewboard.mozilla.org/r/195694/#review200892
Attachment #8924412 - Flags: review?(dao+bmo) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/be60c2b625ae Sync input.css with style in textbox.css. r=dao
You need to log in before you can comment on or make changes to this bug.