Closed Bug 1411460 Opened 2 years ago Closed 2 years ago

stylo: Investigate why editor/reftests/xul/empty-1.xul fails on Windows

Categories

(Core :: CSS Parsing and Computation, defect, P3)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

OS: Unspecified → Windows
Priority: -- → P3
Depends on: 1410074
OK, I think this was regressed by bug 1410233, which changes the corresponding behavior on Windows 10 in theme style sheet but not the testcase. It is not clear to me why that didn't break the test, though. It seems to me this test is broken regardless of whether stylo is enabled.
Blocks: 1410233
Hmmm, but making the stylesheet of reference match textbox.css doesn't fix the test :/
(In reply to Xidorn Quan [:xidorn] UTC+10 (less responsive Nov 5 ~ Dec 16) from comment #2)
> Hmmm, but making the stylesheet of reference match textbox.css doesn't fix
> the test :/

So this is because reftest doesn't rebuild reftest.jar, and thus the input.css file used in those tests are not updated.

reftest.jar is not updated even with `mach build faster` :/

Anyway, having the media condition in input.css match that in textbox.css makes this test pass for me locally. I'll do a try push to confirm.
Comment on attachment 8924412 [details]
Bug 1411460 - Sync input.css with style in textbox.css.

https://reviewboard.mozilla.org/r/195694/#review200892
Attachment #8924412 - Flags: review?(dao+bmo) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be60c2b625ae
Sync input.css with style in textbox.css. r=dao
https://hg.mozilla.org/mozilla-central/rev/be60c2b625ae
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee: nobody → xidorn+moz
You need to log in before you can comment on or make changes to this bug.