Closed
Bug 1410379
Opened 7 years ago
Closed 7 years ago
Deadcode in nsIncrementalStreamLoader::OnStartRequest on logical comparison
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
Details
Attachments
(1 file)
I've tried to build fx with the latest clang trunk version with treat warnings as errors and i got this:
>>/data/jenkins/workspace/firefox-clang-last/netwerk/base/nsIncrementalStreamLoader.cpp:72:35: error: comparison 'uint64_t' (aka >>'unsigned long') > 18446744073709551615 is always false [-Werror,-Wtautological-constant-compare]
>> if (uint64_t(contentLength) > std::numeric_limits<size_t>::max()) {
The error seems to be legit since on 64bit platforms the size of uint64_t coincides with the size of size_t. I think we should have this logic only on 32bit platforms.
Assignee | ||
Updated•7 years ago
|
No longer blocks: coverity-analysis
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8920559 [details]
Bug 1410379 - compare uint64_t with size_t only on 32bit platforms.
https://reviewboard.mozilla.org/r/191562/#review196764
Attachment #8920559 -
Flags: review?(valentin.gosu) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c545c4ae3e18
compare uint64_t with size_t only on 32bit platforms. r=valentin
Updated•7 years ago
|
Blocks: build-gcc-8
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•