1410512 - Add support for getting nightly, beta and release partials for Thunderbird.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement, P3)

Description

[Tom Prince [:tomprince]]

https://hg.mozilla.org/mozilla-central/file/d1e995c8640a/taskcluster/taskgraph/decision.py#l191

Comment 2

[Rob Lemley [:rjl]]

Attachment: partial_updates.patch

WIP.
THough it does seem to be working as it produced a few files:
http://ftp.stage.mozaws.net/pub/thunderbird/nightly/partials/2020/02/2020-02-04-02-25-07-try-comm-central/

Comment 3

[Rob Lemley [:rjl]]

Attachment: partial_updates_part_2.patch

For partial updates the parameters to the decision task need to include
release history.
Requires D61636 from bug 1609987.

Comment 4

[Rob Lemley [:rjl]]

Attachment: partial_updates.patch

Set up the tasks for creating partial updates. This patch alone won't do
anything.

Comment 5

[Rob Lemley [:rjl]]

Attachment: partial_updates_part_2.patch

Requires D61636 on M-C; that's currently on autoland.
Uses the same function as Firefox to get the recent release history from
Balrog.

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9124585 [details] [diff] [review]
partial_updates.patch

Review of attachment 9124585 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: taskcluster/ci/partials/kind.yml
@@ +28,5 @@
> +    - win32-nightly/opt
> +    - win64-shippable/opt
> +    - win64-nightly/opt
> +
> +

Extra empty line.

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9124587 [details] [diff] [review]
partial_updates_part_2.patch

Review of attachment 9124587 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/comm_taskgraph/__init__.py
@@ +41,5 @@
> +
> +    parameters.setdefault('release_history', dict())
> +    if 'nightly' in parameters.get('target_tasks_method', ''):
> +        parameters['release_history'] = populate_release_history(BALROG_PRODUCT,
> +                                                                 project)

You've got 99 characters to work with in Python, no need for this ugly wrapping. :/

Comment 8

[Rob Lemley [:rjl]]

Attachment: partial_updates.patch

Comment 9

[Rob Lemley [:rjl]]

Attachment: partial_updates_part_2.patch

Comment 10

[Rob Lemley [:rjl]]

Attachment: partial_updates_part_2.patch

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fbdc28c1011c
Build partial update MARs for Thunderbird. r=darktrojan
https://hg.mozilla.org/comm-central/rev/010e3872fa13
Include release history on nightly builds. r=darktrojan

Comment 12

[Rob Lemley [:rjl]]

https://hg.mozilla.org/comm-central/rev/fbdc28c1011c
https://hg.mozilla.org/comm-central/rev/010e3872fa13

Comment 13

[Rob Lemley [:rjl]]

Attachment: partial_updates_part_3.patch

I need to look into getting a cache set up for Thunderbird, if it's necessary
at all. I will update this bug with findings. In the meantime, we can at least
build and test the updates themselves.

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 9125158 [details] [diff] [review]
partial_updates_part_3.patch

Review of attachment 9125158 [details] [diff] [review]:
-----------------------------------------------------------------

rs=mkmelin

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/edd42b546bfe
Follow-up: Disable mbsdiff cache when building partial updates. rs=mkmelin

Comment 16

[Rob Lemley [:rjl]]

As far as the cache goes, it's not necessary. It may save some time when promoting a release, so I can watch the build times and go from there.

Comment 17

[Rob Lemley [:rjl]]

Partials generated this morning.

Verified working on:

• Linux - Walt
• macOS - Rob
• Win64 - Rob

Comment 18

[Rob Lemley [:rjl]]

Comment on attachment 9125158 [details] [diff] [review]
partial_updates_part_3.patch

Here's the uplift request for partials on esr68 as requested. There's a dependency on parts of bug 1609987.
https://hg.mozilla.org/comm-central/rev/fbdc28c1011c
https://hg.mozilla.org/comm-central/rev/010e3872fa13
https://hg.mozilla.org/comm-central/rev/edd42b546bfe

In order to get this to work on esr68 we need on our THUNDERBIRD_68_VERBRANCH: (I haven't verified these will uplift cleanly yet)
**D60540	Bug 1609987 - Port bug 1568006: Add project's taskgraph directory to the python path.
D61636	Bug 1609987 - Port bug 1568006: Allow projects to modify decision parameters.**

As well as:
Bug 1609987 attachment 9122792 [details] [diff] [review] uplifted to comm-esr68

Comment 19

[Rob Lemley [:rjl]]

Comment on attachment 9124866 [details] [diff] [review]
partial_updates.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):

Comment 20

[Rob Lemley [:rjl]]

Attachment: comm-esr68_partials_combined_uplift.patch

[Approval Request Comment]
We an get partials comm-esr68 without having to make modifications to mozilla-esr68.
Only these two commits are needed:
https://hg.mozilla.org/comm-central/rev/fbdc28c1011c
https://hg.mozilla.org/comm-central/rev/edd42b546bfe

The reason for not needing the Mozilla changes and rev 010e3872fa13: The Mozilla code changes are only necessary to generate the partial updates for Nightly. That line of code is not needed when generating partials for a release build because the versions to build partials for are entered by the release manager when the release is promoted in Ship-It whereas for Nightly releases they are determined automatically based on what's in Balrog.

The remaining commits needed some minor changes to work on c-esr68, so this attachment should be applied directly.

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9130571 [details] [diff] [review]
comm-esr68_partials_combined_uplift.patch

We'll test this during smoketesting.

Comment 22

[Rob Lemley [:rjl]]

Thunderbird 68.6.0:
https://hg.mozilla.org/releases/comm-esr68/rev/9c87ef085d26
https://hg.mozilla.org/releases/comm-esr68/rev/c03f5c39470f