Closed Bug 1410536 Opened 2 years ago Closed 2 years ago

Enabling the dom.webcomponents.customelements.enabled pref causes some talos regressions (dromaeo_dom, maybe tabpaint)

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: bgrins, Assigned: edgar)

References

Details

I noticed some regressions when working on Bugs 1404420 and 1392352, and traced it back to a change in the patch that was flipping the dom.webcomponents.customelements.enabled pref default to true.

Here's a talos comparison with just the pref flipped:

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=10954f719c95fc9b9f15ab718b53d0b4a0d18cf1&newProject=try&newRevision=96c2b42d54abb37a89a9911a39cdcce7bf6bda8e&framework=1&showOnlyImportant=1

dromaeo_dom opt e10s:
  linux64 -6.55% 	
  linux64-qr -8.80%
dromaeo_dom opt e10s stylo_disabled:	
  linux64 -8.15% 	
tabpaint opt e10s:
  windows7-32: 5.87%

I've reproduced the dromaeo_dom regressions on a bunch of pushes. I'm less sure that the tabpaint regression, I haven't seen it on any of the other try pushes.
Blocks: 1396567
Priority: -- → P2
(In reply to Edgar Chen [:edgar] from comment #1)
> Test again on recent m-c, e1d7427787f7,
> https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-
> central&newProject=try&newRevision=81fb795de3ec08f3f76d34367846b42364a9cf6b&f
> ramework=1&selectedTimeRange=172800

dromaeo_dom opt e10s:
  linux64    -8.18%
  linux64-qr -8.97%

dromaeo_dom opt e10s stylo_disabled:
  linux64    -10.50%

dromaeo_dom pgo e10s:
  linux64    -6.84%

dromaeo_dom pgo e10s stylo_disabled:
  linux64    -8.17%
Interesting. That is massive regression.
Depends on: 1392974
Blocks: 1406825
(In reply to Edgar Chen [:edgar] from comment #4)
> Test again on recent m-c (8062887ff0d9),
> https://treeherder.mozilla.org/perf.html#/
> comparechooser?newProject=try&newRevision=375b039ccf54ef59e63a9b40b43a5bdadcf
> 62b44.

dromaeo_dom opt e10s:
  linux64      -0.23% 	
  linux64-qr   -2.82% 

dromaeo_dom opt e10s stylo_disabled:
  linux64      -3.10%

dromaeo_dom pgo e10s:
  linux64      0.10%

dromaeo_dom pgo e10s stylo_disabled:
  linux64      -0.06%
pgo builds are the interesting ones.
Speedometer results would be interesting too.
(In reply to Olli Pettay [:smaug] (won't be in Austin) from comment #6)
> Speedometer results would be interesting too.

(In reply to Edgar Chen [:edgar] from comment #1)
> Test again on recent m-c, e1d7427787f7,
> https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-
> central&newProject=try&newRevision=81fb795de3ec08f3f76d34367846b42364a9cf6b&f
> ramework=1&selectedTimeRange=172800

Here is the result of speedometer in talos run:

speedometer opt e10s:
  linux64       -0.54% 	
  linux64-qr    -0.35% 	 	
  osx-10-10     0.20%
  windows10-64  -0.82% 		
  windows7-32   -1.00% 	

speedometer opt e10s stylo_disabled:
  linux64       -0.67%

speedometer pgo e10s:
  linux64       -0.95% 	
  windows10-64  0.73%
  windows7-32   -0.62%

speedometer pgo e10s stylo_disabled:
  linux64       0.30%
The result of talos run in comment #4 looks good, so close this bug. Feel free to reopen or file a new bug if you see it again.
Assignee: nobody → echen
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.