Closed
Bug 1410666
Opened 7 years ago
Closed 7 years ago
Remove unused PanelUI-popup code
Categories
(Firefox :: Theme, enhancement, P1)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: ntim, Assigned: jaws)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-structure])
Attachments
(1 file, 1 obsolete file)
Old panel code has been removed in bug 1354117.
|
Reporter | |
Updated•7 years ago
|
Summary: Remove unused CSS from panelUI.inc.css → Remove unused PanelUI-popup code
|
|
Reporter | |
Updated•7 years ago
|
Assignee: ntim.bugs → nobody
|
|
Reporter | |
Comment 1•7 years ago
|
||
I've attached a WIP. I'm not planning to work on this further, so feel free to steal this. Here's what's left to do: - Removing more strings - Fixing the bookmarks menu checkmark - Looking if there's more stuff to remove
|
||
Updated•7 years ago
|
Whiteboard: [photon-structure][triage]
|
||
Updated•7 years ago
|
Priority: -- → P4
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
|
|
||
Updated•7 years ago
|
Blocks: photon-structure
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
|
||
Updated•7 years ago
|
Priority: P4 → P1
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8920835 -
Attachment is obsolete: true
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8923924 [details] Bug 1410666 - Remove unused PanelUI-popup code. https://reviewboard.mozilla.org/r/195084/#review200634 Phew, that was hard to review. :) I think it seems okay - one (maybe) alignment issue, but otherwise seems good. Thanks! ::: browser/components/customizableui/content/panelUI.inc.xul:355 (Diff revision 2) > key="key_quitApplication" > command="cmd_quitApplication"/> > #endif > </vbox> > </panelview> > + <panelview id="PanelUI-history" flex="1"> Is the alignment here busted, or is MozReview confusing me?
Attachment #8923924 -
Flags: review?(mconley) → review+
| Comment hidden (mozreview-request) |
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b558ad2372bf Remove unused PanelUI-popup code. r=mconley
|
||
Comment 7•7 years ago
|
||
Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b558ad2372bf606da4f1e06f92be348cb7fbc78a https://treeherder.mozilla.org/logviewer.html#?job_id=141467978&repo=autoland&lineNumber=3302 https://hg.mozilla.org/integration/autoland/rev/f348675cfbf78fc8ad5a797d3cd230bff1dd4392
Flags: needinfo?(jaws)
| Comment hidden (mozreview-request) |
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef5b98d6c07d Remove unused PanelUI-popup code. r=mconley
|
||
Comment 10•7 years ago
|
||
Errr, this is a dupe of bug 1388029. Is there anything left to do in that bug, or should that bug be closed as a dupe of this one, seeing as this has landed now?
|
||
Comment 11•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ef5b98d6c07d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
|
Assignee | |
Comment 12•7 years ago
|
||
(In reply to :Gijs (no reviews; PTO recovery mode) from comment #10) > Errr, this is a dupe of bug 1388029. Is there anything left to do in that > bug, or should that bug be closed as a dupe of this one, seeing as this has > landed now? Looking at searchfox and DXR, there are still mentions of AREA_PANEL that can be removed.
Flags: needinfo?(jaws)
You need to log in
before you can comment on or make changes to this bug.
Description
•