1410666 - Remove unused PanelUI-popup code

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Tim Nguyen :ntim]

Old panel code has been removed in bug 1354117.

Comment 1

[Tim Nguyen :ntim]

Attachment: WIP-PanelUI.patch

I've attached a WIP.

I'm not planning to work on this further, so feel free to steal this.

Here's what's left to do:
- Removing more strings
- Fixing the bookmarks menu checkmark
- Looking if there's more stuff to remove

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1410666 - Remove unused PanelUI-popup code.

Original patch authored by Tim Nguyen (:ntim).

Review commit: https://reviewboard.mozilla.org/r/195084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195084/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8923924 [details]
Bug 1410666 - Remove unused PanelUI-popup code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195084/diff/1-2/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8923924 [details]
Bug 1410666 - Remove unused PanelUI-popup code.

https://reviewboard.mozilla.org/r/195084/#review200634

Phew, that was hard to review. :)

I think it seems okay - one (maybe) alignment issue, but otherwise seems good. Thanks!

::: browser/components/customizableui/content/panelUI.inc.xul:355
(Diff revision 2)
>                         key="key_quitApplication"
>                         command="cmd_quitApplication"/>
>  #endif
>        </vbox>
>      </panelview>
> +        <panelview id="PanelUI-history" flex="1">

Is the alignment here busted, or is MozReview confusing me?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8923924 [details]
Bug 1410666 - Remove unused PanelUI-popup code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195084/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b558ad2372bf
Remove unused PanelUI-popup code. r=mconley

Comment 7

[Cristina Coroiu [:ccoroiu]]

Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b558ad2372bf606da4f1e06f92be348cb7fbc78a

https://treeherder.mozilla.org/logviewer.html#?job_id=141467978&repo=autoland&lineNumber=3302

https://hg.mozilla.org/integration/autoland/rev/f348675cfbf78fc8ad5a797d3cd230bff1dd4392

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8923924 [details]
Bug 1410666 - Remove unused PanelUI-popup code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195084/diff/3-4/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef5b98d6c07d
Remove unused PanelUI-popup code. r=mconley

Comment 10

[:Gijs (he/him)]

Errr, this is a dupe of bug 1388029. Is there anything left to do in that bug, or should that bug be closed as a dupe of this one, seeing as this has landed now?

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ef5b98d6c07d

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to :Gijs (no reviews; PTO recovery mode) from comment #10)
> Errr, this is a dupe of bug 1388029. Is there anything left to do in that
> bug, or should that bug be closed as a dupe of this one, seeing as this has
> landed now?

Looking at searchfox and DXR, there are still mentions of AREA_PANEL that can be removed.