Closed Bug 1410745 Opened 2 years ago Closed 2 years ago

Remove spacing between attachmentitems on Windows default theme

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

For bug 229224 we need to remove the spacing between the attachmentitems on Windows default theme
This removes the gap between the attachmentitems and looks now because of this more like a Explorer list.

I also added a 1px padding in attacjmentBucket to make the focus highlight better visible.

The many -moz-border-* changes in attachmentList.css are white space changes to make the rgba() notations consistent. The last change in this file is to make the borders not too strong looking when two or more attachmentitems are touching and are selected.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8921613 - Flags: review?(jorgk)
I assume we're talking about the attachments in the attachment bucket in a new e-mail.

On Windows 7 I see no difference compared to a Daily which is a few days old. "Gap between items" has changed?
Yes, there is a 1px gap between the items without the patch that leads to the issue Thomas noted in bug 229224 when dragging them over other items. I can make a screenshot this evening.
Comment on attachment 8921613 [details] [diff] [review]
attachment-style.patch

OK, I can see the difference now when attaching 10+ items. Before I only added three.
Attachment #8921613 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/260d49e11c29
Fix spacing between attachment items in attachment bucket. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
Richard, please remove the focus border from attachment listbox (big square). At first I thought it's a bug.
- apart from visual noise, it does not add anything, because there's a clear and non-ambiguous focus indication on the focused item: special border and darker blue background if focused and selected.
- it is technically misleading/incorrect/confusing, because focus is NOT on the bucket, but on the focused item inside the bucket.
- it is needlessly deviating from platform focus standards, and our own standards in other listboxes like contacts side bar
(- it is incomplete: missing border on the right)
I just realize that it's better than before, but it's still not correct/perfect.

Please try to make it exactly as in windows Explorer, which is almost exactly as in contacts sidebar:
- selected, but not focused: no border on left and right, inside border with weaker border-color, no outside border at selection edge (no border-top of top item/no border-bottom of bottom item of selection).
- selected and focused: 4-sides border, emphasized with stronger border-color

Contacts sidebar is almost there, but two minor flaws:
- selected & focused item has stronger top border, which isn't intended I think
- last selected item has bottom border and shouldn't

After that, we can test/discuss if there's any way to emphasize the 4-side focus border more, I guess just making it a bit darker would suffice (2px might look odd and cause jumping problems).
And please use exactly same colors as for contacts side bar. I wonder if we don't have standardized colors for that, instead of hard-coding everywhere?
This bug is fixed. Further work needs a new bug.

(In reply to Thomas D. (currently busy elsewhere) from comment #7)
> I just realize that it's better than before, but it's still not
> correct/perfect.
> 
> Please try to make it exactly as in windows Explorer, which is almost
> exactly as in contacts sidebar:
> - selected, but not focused: no border on left and right, inside border with
> weaker border-color, no outside border at selection edge (no border-top of
> top item/no border-bottom of bottom item of selection).

What for a strange Explorer do you have. I see always borders on all sides

> - selected and focused: 4-sides border, emphasized with stronger border-color
> 
> Contacts sidebar is almost there, but two minor flaws:
> - selected & focused item has stronger top border, which isn't intended I
> think
> - last selected item has bottom border and shouldn't

Again, my Explorer has always all four borders. Please show screenshots, but not in this bug.

> After that, we can test/discuss if there's any way to emphasize the 4-side
> focus border more, I guess just making it a bit darker would suffice (2px
> might look odd and cause jumping problems).

Can be done.
Blocks: 1412758
You need to log in before you can comment on or make changes to this bug.