Closed Bug 1410876 Opened 2 years ago Closed 2 years ago

layout/base/nsLayoutUtils.cpp:4039:5: error: 'AutoProfilerTracing' was not declared in this scope

Categories

(Core :: Web Painting, defect, P3)

Unspecified
FreeBSD
defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: jbeich, Assigned: miko)

References

Details

(Keywords: regression)

Attachments

(1 file)

On Tier3 platforms without GeckoProfiler (iOS, Linux non-x86, BSDs, Solaris) the build is broken because "GeckoProfiler.h" doesn't define AutoProfilerTracing[1]. To reproduce on Tier1 platforms before bug 1371159 is fixed one has to force `return None` in gecko_profiler()[2].

In file included from objdir/layout/base/Unified_cpp_layout_base1.cpp:128:
layout/base/nsLayoutUtils.cpp:4039:5: error: unknown type name 'AutoProfilerTracing'
    AutoProfilerTracing tracing("Paint", "DisplayListResources");
    ^
1 error generated.

[1] http://searchfox.org/mozilla-central/rev/ed1d5223adcd/tools/profiler/public/GeckoProfiler.h#613
[2] http://searchfox.org/mozilla-central/rev/ed1d5223adcd/toolkit/moz.configure#26
Did you mean to use AUTO_PROFILER_TRACING instead per bug 1403868?
Flags: needinfo?(matt.woodrow)
Assignee: nobody → mikokm
(In reply to Jan Beich from comment #1)
> Did you mean to use AUTO_PROFILER_TRACING instead per bug 1403868?

Yes. I added this code earlier to another repository that was recently merged with mozilla-central.

Could you please very that this patch fixes the compile error?
Flags: needinfo?(matt.woodrow) → needinfo?(jbeich)
Comment on attachment 8921037 [details]
Bug 1410876 - Use AUTO_PROFILER_TRACING instead of AutoProfilerTracing

I confirm, this unbreaks build on FreeBSD.
Flags: needinfo?(jbeich)
Attachment #8921037 - Flags: feedback+
Status: NEW → ASSIGNED
Comment on attachment 8921037 [details]
Bug 1410876 - Use AUTO_PROFILER_TRACING instead of AutoProfilerTracing

https://reviewboard.mozilla.org/r/191996/#review197370
Attachment #8921037 - Flags: review?(matt.woodrow) → review+
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e1bcd28b3323
Use AUTO_PROFILER_TRACING instead of AutoProfilerTracing r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/e1bcd28b3323
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
No longer blocks: 1467514
You need to log in before you can comment on or make changes to this bug.