1410876 - layout/base/nsLayoutUtils.cpp:4039:5: error: 'AutoProfilerTracing' was not declared in this scope

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Description

[Jan Beich]

On Tier3 platforms without GeckoProfiler (iOS, Linux non-x86, BSDs, Solaris) the build is broken because "GeckoProfiler.h" doesn't define AutoProfilerTracing[1]. To reproduce on Tier1 platforms before bug 1371159 is fixed one has to force `return None` in gecko_profiler()[2].

In file included from objdir/layout/base/Unified_cpp_layout_base1.cpp:128:
layout/base/nsLayoutUtils.cpp:4039:5: error: unknown type name 'AutoProfilerTracing'
    AutoProfilerTracing tracing("Paint", "DisplayListResources");
    ^
1 error generated.

[1] http://searchfox.org/mozilla-central/rev/ed1d5223adcd/tools/profiler/public/GeckoProfiler.h#613
[2] http://searchfox.org/mozilla-central/rev/ed1d5223adcd/toolkit/moz.configure#26

Comment 1

[Jan Beich]

Did you mean to use AUTO_PROFILER_TRACING instead per bug 1403868?

Comment 2

[Miko Mynttinen]

Attachment: Bug 1410876 - Use AUTO_PROFILER_TRACING instead of AutoProfilerTracing

Review commit: https://reviewboard.mozilla.org/r/191996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191996/

Comment 3

[Miko Mynttinen]

(In reply to Jan Beich from comment #1)
> Did you mean to use AUTO_PROFILER_TRACING instead per bug 1403868?

Yes. I added this code earlier to another repository that was recently merged with mozilla-central.

Could you please very that this patch fixes the compile error?

Comment 4

[Jan Beich]

Comment on attachment 8921037 [details]
Bug 1410876 - Use AUTO_PROFILER_TRACING instead of AutoProfilerTracing

I confirm, this unbreaks build on FreeBSD.

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8921037 [details]
Bug 1410876 - Use AUTO_PROFILER_TRACING instead of AutoProfilerTracing

https://reviewboard.mozilla.org/r/191996/#review197370

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1bcd28b3323
Use AUTO_PROFILER_TRACING instead of AutoProfilerTracing r=mattwoodrow

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e1bcd28b3323