1410893 - Update webrender to 4b8493d6bdc64d2d83202ac15b06b0d4b14c6e76

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1409736 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 96ec91319d9d0b6f1c3bc47b95be835bfc087e2d

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7feb082bba3567e227f83460a7b2316844281d8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6b45b22c0b27a6eea2ab4bf0c32fb426f3f683c

Green

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ a182bf7483c5ba10934dd7f9470dbc812186a1d9

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7c9e3442807cdac0e36e0bee50d9ac29c9004f4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b333868d4fc464ae68b403cafcadeeca6bb7da0

Green

WR @ 205cd083421dc7ed026fbcd63e82fff77420112d

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ca77016d60c81d663529249f59dfb0aebce994e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=517a691609b3fd202c1132b9be46067a61923e16

Green except for a slight increase in fuzziness for css-break/box-decoration-break-with-inset-box-shadow-1.html in R4. Regression range is

*   205cd083 Auto merge of #1910 - mstange:multiply-clip, r=glennw
|\
| * c42466c0 Always multiply alpha with the clip's alpha.
* 38f1d656 Auto merge of #1911 - mstange:bright-text-macos, r=glennw
* 8f3d9d7b Draw white on black if the font is bright, because bright text uses a different amount of font dilation.

So it's probably from servo/webrender#1910. (Related to this reftest: bug 1411074)

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ 3b1cf1e6ae80a3e7181a162149650c5bc55faf67

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f66ae872c144fef49dc8559a4847b7e97eeda95
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a21bc2a965f49106e552b06a98501a861e81f22

Slight increase in fuzziness for transform-3d/backface-visibility-2.html in R8.

Regression range:

*   3b1cf1e6 Auto merge of #1915 - mstange:fix-intel-clipping, r=glennw
|\
| * 854f8738 Use a different workaround that fixes both #1809 and #1738.
* bf1869de Auto merge of #1914 - mstange:premultiplied-rectangle, r=glennw
* 3da0b935 Use premultiplied blending for rectangle primitives.

Probably from servo/webrender#1918.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

.. err I meant servo/webrender#1914

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 1cb8e7f016ef3c4dcd579e8c1b3350abcf39d331

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fd277bbdd0b03418f36f368a10d73d8a6f9a47b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad24fac98d88b379deee1e9696b790ba745f4c02

Green with a side of decreased fuzziness in css-break/box-decoration-break-with-inset-box-shadow-1.html in R4. Regression range is

* 1cb8e7f0 Auto merge of #1918 - glennw:bs-spread, r=kvark
* 782ca07d Fix inset box shadows with spread radius > border radius.

I tweaked the fuzz numbers to compensate.


WR @ f0ae29eadc6c9c3260639af1e625fd075fcd0af3

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5053406d9bf46036d48b6db8780dd2358829c53f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=02b2184a190045c9a07f500e91088a760677ad66

Green

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Right now builds are broken as of servo/webrender#1923. Gankro provided a gecko patch in that issue but it requires bug 1401653 to be in first, and that just got backed out of autoland. So we're on hold until that gets sorted out.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

I guess I can do a try push at 18137a6a, just before #1923 got merged.

WR @ 18137a6a2093145963e93675e8d2cae55e2c4012

https://treeherder.mozilla.org/#/jobs?repo=try&revision=01e1057d8675849362583753f7ab9e79de3fb237
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c89c2d40eb706bc1c33974fc9984d666fc6c76b5

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ 927c12ad211c8c750a4e7ed4991b9e20ecba33b5 based on autoland and with Gankro's fixup from https://github.com/servo/webrender/pull/1923#issuecomment-339141830:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=88abace52466e310620aba2a32c462cb5826050c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bb4ae11619b3bae10264f3bd489636531e8f8f7

Builds, so that's good. Tests are pending still

Comment 9

[Kartikaya Gupta (email:[e-mail])]

WR @ 42263344b9820e7252a617a8d2a54f9e0e9565f3

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e5fddfb10f1e8b09e096453fb1a773110e96024
https://treeherder.mozilla.org/#/jobs?repo=try&revision=24e80c5ba5a718591ea072a217d96fa0a3bc9935

Green

WR @ 038a223b5ec14086ff2cd77832e90c15d0453cd2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=acb1480b5c0bce81311095a5a00ed33c1330d42c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e815619509020b16ccbaea40a4f9e2892e8a210e

Much orange, looks like a crash in texture cache locking code. Regression range:

*   038a223b Auto merge of #1945 - lsalzman:color-bitmap-blend, r=glennw
|\
| * 9fb8ab8f remember GlyphFormat in glyph cache and pass to text run shader
*   c47d106c Auto merge of #1920 - mephisto41:improve-blur, r=glennw
|\
| * e1f0c80e Tweak blur filter.
* 844779d1 Auto merge of #1942 - kvark:flatten, r=glennw
* 72692761 Move flattening logic into FlattenContext
* 18b12e50 Synchonized font instance map

Nothing here looks super relevant so it might be a regression on the gecko side. I'll do some more try pushes to narrow it down.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

I did the cross-build try pushes:

new WR with older autoland cset [1] - busted
old WR with newer m-c cset [2] - green

So this is definitely a breakage from a change in upstream WR. Bisecting the range from the last comment, but #1942 looks like the most likely culprit.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=346514879173d2bebc49ba846b9819c2dfa93b86
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=705b6c62699a7ded031e0d2cc1e8b66c2b525d1d

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Bisection push with WR @ 844779d1 confirms bustage: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4773a25f60ecf0e6cc22a615998a621f0e00586

So #1942 is definitely where it's coming from. :kvark is looking into it.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

The fix is in servo/webrender#1948. Try push with that applied is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=08b5790d2d7842580be509e4a516611a1f3bdccf - there are a bunch of reftest changes from #1920. I'll update the reftest results for those.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

WR @ 82e6085a14cc6d4025ca43d899847f125043adb2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=27494c0354a5ac19881a2d3981190119eb2a9913
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e349334468a4c017dbb1e0a2ae09a273ac5dcbb7

(most things still pending)

Comment 14

[Kartikaya Gupta (email:[e-mail])]

^ Linux is green (The R7 failure is because I fat-fingered one of the reftest adjustments). But Windows is red, getting another shader compilation failure:

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Link("debug_font", "Precisions for uniform \'uMode\' differ between vertex and fragment shaders\n")', src\libcore\result.rs:906:4

Looking back the try pushes the regression range for this is:

*   038a223b Auto merge of #1945 - lsalzman:color-bitmap-blend, r=glennw
|\
| * 9fb8ab8f remember GlyphFormat in glyph cache and pass to text run shader
*   c47d106c Auto merge of #1920 - mephisto41:improve-blur, r=glennw
|\
| * e1f0c80e Tweak blur filter.
* 844779d1 Auto merge of #1942 - kvark:flatten, r=glennw
* 72692761 Move flattening logic into FlattenContext
* 18b12e50 Synchonized font instance map

Based on the diffs I think this is coming from 9fb8ab8f, aka servo/webrender#1945.

Comment 15

[Dzmitry Malyshau [:kvark]]

Proposed workaround in https://github.com/servo/webrender/pull/1952

Comment 16

[Kartikaya Gupta (email:[e-mail])]

WR @ 44c8219f5f580aa563353aab42378bd33c5cffba

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8fb475378f7aaab34a475fd6f0dff5ba6b82f75
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d565f22e063de79cd5e53dbd8b59dbe5f7efde05

This one is before #1952 landed, and still has the shader compilation failures. Rest is green


WR @ ca3c73d59fa8be4b502659dd1581aba2cce2d19f

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f04e6e7f4343b0c1215730824a39a6242849dd23
https://treeherder.mozilla.org/#/jobs?repo=try&revision=40435d873abe0326b3fd700a0fc64e7afc3b3888

This one includes #1952, and is green. Yay!


WR @ 4b8493d6bdc64d2d83202ac15b06b0d4b14c6e76

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7db67b3f9473b3db04b71b41cdba23b9efc053da
https://treeherder.mozilla.org/#/jobs?repo=try&revision=03a4020ea9e6ec8d2ebee71e1159c049e2da8b58

Green

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1410893 - Update webrender to commit 4b8493d6bdc64d2d83202ac15b06b0d4b14c6e76.

Review commit: https://reviewboard.mozilla.org/r/193936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193936/

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1410893 - Update Cargo lockfiles and re-generate FFI header.

Review commit: https://reviewboard.mozilla.org/r/193938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193938/

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1410893 - Update reftest results for changes in WR PR 1910.

The reftest box-decoration-break-with-inset-box-shadow-1.html was affected
by both PR 1910 and PR 1918.
The reftest backface-visibility-2.html was affected by PR 1914.

Review commit: https://reviewboard.mozilla.org/r/193940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193940/

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1410893 - Update bindings for API changes in WR PR 1923.

Review commit: https://reviewboard.mozilla.org/r/193942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193942/

Comment 21

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1410893 - Update reftest results for WR PR 1920.

Review commit: https://reviewboard.mozilla.org/r/193944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/193944/

Comment 22

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8922785 [details]
Bug 1410893 - Update webrender to commit 4b8493d6bdc64d2d83202ac15b06b0d4b14c6e76.

https://reviewboard.mozilla.org/r/193936/#review199038

Comment 23

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8922786 [details]
Bug 1410893 - Update Cargo lockfiles and re-generate FFI header.

https://reviewboard.mozilla.org/r/193938/#review199040

Comment 24

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8922787 [details]
Bug 1410893 - Update reftest results for changes in WR PR 1910.

https://reviewboard.mozilla.org/r/193940/#review199044

Comment 25

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8922788 [details]
Bug 1410893 - Update bindings for API changes in WR PR 1923.

https://reviewboard.mozilla.org/r/193942/#review199046

Comment 26

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8922789 [details]
Bug 1410893 - Update reftest results for WR PR 1920.

https://reviewboard.mozilla.org/r/193944/#review199050

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55f33f1364a7
Update webrender to commit 4b8493d6bdc64d2d83202ac15b06b0d4b14c6e76. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0eb02890fae4
Update Cargo lockfiles and re-generate FFI header. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a94e6f39f062
Update reftest results for changes in WR PR 1910. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/1fd7e1d19df0
Update bindings for API changes in WR PR 1923. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a9eb465811d0
Update reftest results for WR PR 1920. r=jrmuizel

Comment 28

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/55f33f1364a7
https://hg.mozilla.org/mozilla-central/rev/0eb02890fae4
https://hg.mozilla.org/mozilla-central/rev/a94e6f39f062
https://hg.mozilla.org/mozilla-central/rev/1fd7e1d19df0
https://hg.mozilla.org/mozilla-central/rev/a9eb465811d0