Closed Bug 1409736 Opened 2 years ago Closed 2 years ago

Update webrender to d741f472dd3d6c3441646f7bf4e714c71bea39b7

Categories

(Core :: Graphics: WebRender, enhancement, P1)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: kats, Assigned: kats)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(7 files, 1 obsolete file)

59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
59 bytes, text/x-review-board-request
Gankra
: review+
jrmuizel
: review+
Details
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
59 bytes, text/x-review-board-request
jrmuizel
: review+
Details
+++ This bug was initially created as a clone of Bug #1408461 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
WR @ 0df0df10021cd31cc23f2081b64a07cdfb9342eb

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cd4422b0abf77654a09b600393760d7515f726a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd161c1fe34e1ad53ace07f248b6d7e3cd9eb412

We haz a problem. Lots of this going on:
  GECKO(1114) | thread 'RenderBackend' panicked at 'MEH: malicious input?: Custom("invalid value: integer `3857049061`, expected variant index 0 <= i < 2")', /checkout/src/libcore/result.rs:906:4

Regression range:
* 0df0df10 Auto merge of #1867 - glennw:fix-1862, r=mrobinson
* 69bbb68c Expose ClipMode in public API.
WR @ b0372a8752bbaa36e7179ea58ec5d992833bf19d

https://treeherder.mozilla.org/#/jobs?repo=try&revision=383babdb74998fd2abebdcfcce237bf922a330a9
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c953097015ffaab7853a0c5d6343f7e6a5934954

Green

WR @ 9d502a1088659219375e11c6244bebe2ee6179ca

https://treeherder.mozilla.org/#/jobs?repo=try&revision=17a94a661e80cfc61b18dea2eb5607e34018ac5b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=66a8e7614da13ddb29c427da8da179e5c8f65326

unexpected-pass on reftests/bugs/1156129-1.html. regression range:

*   9d502a10 (HEAD -> master, origin/master, origin/auto, origin/HEAD) Auto merge of #1901 - glennw:fix-1897, r=nical
|\
| * 635d1441 Fix border corners with zero widths being drawn.
| * 917e4f94 add reftest for #1897
*   50c6f9ad Auto merge of #1900 - nnethercote:rm-heapsize, r=glennw
|\
| * 53364c9a Remove `heapsize` dependency.
*   56a452d6 Auto merge of #1882 - JerryShih:unique-IdNamespace, r=glennw
|\
| * c551f5f6 Use a global static variable for IdNamespace counting.
* 9e1180d1 Auto merge of #1896 - glennw:edge-blur, r=kvark
* 764178af Address review comments
* 509075ef Optimize box shadows - only apply blurs where they can affect the shadow.
The unexpected-pass doesn't happen at 9e1180d124b450ca4493a7cf560e7aae84451119 so it's likely from servo/webrender#1901
WR @ 517ef531a66154b8a214a06f89b76eeaa23e2098

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2acc76fde9d4a6177d6c5e6ba074deaebe095ff5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=955bd7713bbd099c290a4dfc390d81d310da18f9

Busted. Regression range:

*   517ef531 Auto merge of #1836 - Gankro:skip, r=glennw
|\
| * 13bfa65a Optimize skip_slice by recording serialized length
* 7594d8f4 Auto merge of #1903 - jrmuizel:blob-image-dirty, r=Gankro
* 86c7767a Pass the dirty rect down into the blob image

Bustage is from #1903.
I fixed the bustage locally.
Update patch for render notifier API changes.
Alias: wr-future-update
Assignee: nobody → bugmail
Summary: Future webrender update bug → Update webrender to d741f472dd3d6c3441646f7bf4e714c71bea39b7
Version: unspecified → 58 Branch
Comment on attachment 8920927 [details] [diff] [review]
Update patch for notifier changes

Incorporated this into the MozReview patchset
Attachment #8920927 - Attachment is obsolete: true
Comment on attachment 8921052 [details]
Bug 1409736 - Update webrender to commit d741f472dd3d6c3441646f7bf4e714c71bea39b7.

https://reviewboard.mozilla.org/r/192010/#review197214
Attachment #8921052 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8921053 [details]
Bug 1409736 - Update Cargo lockfiles and re-generate FFI header.

https://reviewboard.mozilla.org/r/192012/#review197216
Attachment #8921053 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8921054 [details]
Bug 1409736 - Update bindings for changes in WR PR 1889.

https://reviewboard.mozilla.org/r/192014/#review197218
Attachment #8921054 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8921055 [details]
Bug 1409736 - Initialize the new clip member introduced in WR PR 1867.

https://reviewboard.mozilla.org/r/192016/#review197220
Attachment #8921055 - Flags: review+
Comment on attachment 8921056 [details]
Bug 1409736 - Update reftest failure annotations for changes in WR PR 1901.

https://reviewboard.mozilla.org/r/192018/#review197222
Attachment #8921056 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8921057 [details]
Bug 1409736 - Update for API change in WR PR 1903.

https://reviewboard.mozilla.org/r/192020/#review197224
Attachment #8921057 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8921058 [details]
Bug 1409736 - Update bindings for API changes in WR PR 1904.

https://reviewboard.mozilla.org/r/192022/#review197226
Attachment #8921058 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ade2d65bad9
Update webrender to commit d741f472dd3d6c3441646f7bf4e714c71bea39b7. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/ce878f018694
Update Cargo lockfiles and re-generate FFI header. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0f5a9d7f918e
Update bindings for changes in WR PR 1889. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c826c4b1da2c
Initialize the new clip member introduced in WR PR 1867. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/b8fcf3e74e03
Update reftest failure annotations for changes in WR PR 1901. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/ede85397f7d1
Update for API change in WR PR 1903. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/2fc7e2060d1f
Update bindings for API changes in WR PR 1904. r=jrmuizel
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
Comment on attachment 8921055 [details]
Bug 1409736 - Initialize the new clip member introduced in WR PR 1867.

https://reviewboard.mozilla.org/r/192016/#review197352
Attachment #8921055 - Flags: review?(a.beingessner) → review+
You need to log in before you can comment on or make changes to this bug.