1409736 - Update webrender to d741f472dd3d6c3441646f7bf4e714c71bea39b7

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1408461 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ f959c0bed6e10202b1b21a034544fdb62d60a22e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6aa592a6888634b682da2e08385eefeb0711fb1b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e543f1939fe33ab1e50defbb2f3817cdde204d1

Green

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Also @ f959c0bed6e10202b1b21a034544fdb62d60a22e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fca341d5f5a1fadea595401e4b057a42677d976c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=82239e279d35c34e6a4a6fce793cb7c16d363dd7

Green but looks like a bunch of unrelated intermittents/infra issues.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ f959c0bed6e10202b1b21a034544fdb62d60a22e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=15fed900a8ece97e7e0a34d205b52687b11db74c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c22f94bd8e2156a0f556851586efca5354e55dc

Green

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 0df0df10021cd31cc23f2081b64a07cdfb9342eb

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cd4422b0abf77654a09b600393760d7515f726a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd161c1fe34e1ad53ace07f248b6d7e3cd9eb412

We haz a problem. Lots of this going on:
  GECKO(1114) | thread 'RenderBackend' panicked at 'MEH: malicious input?: Custom("invalid value: integer `3857049061`, expected variant index 0 <= i < 2")', /checkout/src/libcore/result.rs:906:4

Regression range:
* 0df0df10 Auto merge of #1867 - glennw:fix-1862, r=mrobinson
* 69bbb68c Expose ClipMode in public API.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attempt at a fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a219541b80d0b8033cd317125a174bbf3ee2515f

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Missed a spot. Here's another attempt: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c629e67a2845c1c68cfc09726e106c95f4cd2c0e

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 37d531900bcb8e7c09c01759af12493abed8c0e3

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea2b15ce0ec395e01923d5511009551dd030ce03
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0daa6ba6ccae183e63f2664e38c153f83581881f

Green so far

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ b0372a8752bbaa36e7179ea58ec5d992833bf19d

https://treeherder.mozilla.org/#/jobs?repo=try&revision=383babdb74998fd2abebdcfcce237bf922a330a9
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c953097015ffaab7853a0c5d6343f7e6a5934954

Green

WR @ 9d502a1088659219375e11c6244bebe2ee6179ca

https://treeherder.mozilla.org/#/jobs?repo=try&revision=17a94a661e80cfc61b18dea2eb5607e34018ac5b
https://treeherder.mozilla.org/#/jobs?repo=try&revision=66a8e7614da13ddb29c427da8da179e5c8f65326

unexpected-pass on reftests/bugs/1156129-1.html. regression range:

*   9d502a10 (HEAD -> master, origin/master, origin/auto, origin/HEAD) Auto merge of #1901 - glennw:fix-1897, r=nical
|\
| * 635d1441 Fix border corners with zero widths being drawn.
| * 917e4f94 add reftest for #1897
*   50c6f9ad Auto merge of #1900 - nnethercote:rm-heapsize, r=glennw
|\
| * 53364c9a Remove `heapsize` dependency.
*   56a452d6 Auto merge of #1882 - JerryShih:unique-IdNamespace, r=glennw
|\
| * c551f5f6 Use a global static variable for IdNamespace counting.
* 9e1180d1 Auto merge of #1896 - glennw:edge-blur, r=kvark
* 764178af Address review comments
* 509075ef Optimize box shadows - only apply blurs where they can affect the shadow.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

The unexpected-pass doesn't happen at 9e1180d124b450ca4493a7cf560e7aae84451119 so it's likely from servo/webrender#1901

Comment 10

[Kartikaya Gupta (email:[e-mail])]

WR @ 9d502a1088659219375e11c6244bebe2ee6179ca

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ba975c04a351d22e275f313b7648de033fa63f1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=057f8d60c02045d9a6679680bdeb254f228fbcde

Green so far.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

WR @ 517ef531a66154b8a214a06f89b76eeaa23e2098

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2acc76fde9d4a6177d6c5e6ba074deaebe095ff5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=955bd7713bbd099c290a4dfc390d81d310da18f9

Busted. Regression range:

*   517ef531 Auto merge of #1836 - Gankro:skip, r=glennw
|\
| * 13bfa65a Optimize skip_slice by recording serialized length
* 7594d8f4 Auto merge of #1903 - jrmuizel:blob-image-dirty, r=Gankro
* 86c7767a Pass the dirty rect down into the blob image

Bustage is from #1903.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

I fixed the bustage locally.

Comment 13

[Glenn Watson [:gw]]

Attachment: Update patch for notifier changes

Update patch for render notifier API changes.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

WR @ 517ef531a66154b8a214a06f89b76eeaa23e2098 with bustage fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4de2556e5669dd2f7818042ed4bb896ba37479bc
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f443e0e31f3e4287891452ebf4ef61b17973cc1f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e305e850a35e1217c3b31918e92492de50e309d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5132f8f2fa4d838291eb015ce35207a0d2bc23f1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d47a1ecdd26b84a95d79a38b9d4f1591f8450d5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=193c89102a5021ab62ef292542b2b633720e5f9e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=008eff537e837464b94ed0338054dc861f50e169
https://treeherder.mozilla.org/#/jobs?repo=try&revision=12c6eaa1e63f8d77b6c2560236725c49fa57c34c

Some intermittent failures here and there but green.

WR @ d741f472dd3d6c3441646f7bf4e714c71bea39b7

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a676cb6d0ccc3373200501b84d35bc66d3d14b6
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d913c42bbbd84519dcd251b14e642476ccf6b9d6

Green

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1409736 - Update webrender to commit d741f472dd3d6c3441646f7bf4e714c71bea39b7.

Review commit: https://reviewboard.mozilla.org/r/192010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192010/

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1409736 - Update Cargo lockfiles and re-generate FFI header.

Review commit: https://reviewboard.mozilla.org/r/192012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192012/

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1409736 - Update bindings for changes in WR PR 1889.

Review commit: https://reviewboard.mozilla.org/r/192014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192014/

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1409736 - Initialize the new clip member introduced in WR PR 1867.

Review commit: https://reviewboard.mozilla.org/r/192016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192016/

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1409736 - Update reftest failure annotations for changes in WR PR 1901.

Review commit: https://reviewboard.mozilla.org/r/192018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192018/

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1409736 - Update for API change in WR PR 1903.

Review commit: https://reviewboard.mozilla.org/r/192020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192020/

Comment 21

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1409736 - Update bindings for API changes in WR PR 1904.

Review commit: https://reviewboard.mozilla.org/r/192022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192022/

Comment 22

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8920927 [details] [diff] [review]
Update patch for notifier changes

Incorporated this into the MozReview patchset

Comment 23

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8921052 [details]
Bug 1409736 - Update webrender to commit d741f472dd3d6c3441646f7bf4e714c71bea39b7.

https://reviewboard.mozilla.org/r/192010/#review197214

Comment 24

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8921053 [details]
Bug 1409736 - Update Cargo lockfiles and re-generate FFI header.

https://reviewboard.mozilla.org/r/192012/#review197216

Comment 25

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8921054 [details]
Bug 1409736 - Update bindings for changes in WR PR 1889.

https://reviewboard.mozilla.org/r/192014/#review197218

Comment 26

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8921055 [details]
Bug 1409736 - Initialize the new clip member introduced in WR PR 1867.

https://reviewboard.mozilla.org/r/192016/#review197220

Comment 27

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8921056 [details]
Bug 1409736 - Update reftest failure annotations for changes in WR PR 1901.

https://reviewboard.mozilla.org/r/192018/#review197222

Comment 28

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8921057 [details]
Bug 1409736 - Update for API change in WR PR 1903.

https://reviewboard.mozilla.org/r/192020/#review197224

Comment 29

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8921058 [details]
Bug 1409736 - Update bindings for API changes in WR PR 1904.

https://reviewboard.mozilla.org/r/192022/#review197226

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ade2d65bad9
Update webrender to commit d741f472dd3d6c3441646f7bf4e714c71bea39b7. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/ce878f018694
Update Cargo lockfiles and re-generate FFI header. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0f5a9d7f918e
Update bindings for changes in WR PR 1889. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c826c4b1da2c
Initialize the new clip member introduced in WR PR 1867. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/b8fcf3e74e03
Update reftest failure annotations for changes in WR PR 1901. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/ede85397f7d1
Update for API change in WR PR 1903. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/2fc7e2060d1f
Update bindings for API changes in WR PR 1904. r=jrmuizel

Comment 31

[Aria Beingessner [:Gankra]]

Comment on attachment 8921055 [details]
Bug 1409736 - Initialize the new clip member introduced in WR PR 1867.

https://reviewboard.mozilla.org/r/192016/#review197352

Comment 32

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7ade2d65bad9
https://hg.mozilla.org/mozilla-central/rev/ce878f018694
https://hg.mozilla.org/mozilla-central/rev/0f5a9d7f918e
https://hg.mozilla.org/mozilla-central/rev/c826c4b1da2c
https://hg.mozilla.org/mozilla-central/rev/b8fcf3e74e03
https://hg.mozilla.org/mozilla-central/rev/ede85397f7d1
https://hg.mozilla.org/mozilla-central/rev/2fc7e2060d1f