1411037 - Disable -Werror on -Wmultistatement-macros

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

/root/firefox-gcc-last/xpcom/base/nsConsoleService.cpp: In member function 'virtual nsresult nsConsoleService::QueryInterface(const nsIID&, void**)':
 /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/nsISupportsImpl.h:970:5: error: macro expands to multiple statements [-Werror=multistatement-macros]
      foundInterface = 0;                                                       \
      ^~~~~~~~~~~~~~

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1411037 - Disable -Werror on -Wmultistatement-macros. Would be a pain to fix all occurrences, for very little gain

Review commit: https://reviewboard.mozilla.org/r/227372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227372/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8958410 [details]
Bug 1411037 - Disable -Werror on -Wmultistatement-macros. Would be a pain to fix all occurrences, for very little gain

https://reviewboard.mozilla.org/r/227372/#review233158

Thank you!

::: build/moz.configure/warnings.configure:102
(Diff revision 1)
>  check_and_add_gcc_warning('-Wno-error=coverage-mismatch', when='MOZ_PGO')
>  
>  # false positives depending on optimizations
>  check_and_add_gcc_warning('-Wno-error=free-nonheap-object')
>  
> +# Would be a pain to fix that in all occurrences for a small gain

Nit: I'd word this as "Would be a pain to fix all occurrences, for very little gain."

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8958410 [details]
Bug 1411037 - Disable -Werror on -Wmultistatement-macros. Would be a pain to fix all occurrences, for very little gain

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227372/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8861684c3209
Disable -Werror on -Wmultistatement-macros. Would be a pain to fix all occurrences, for very little gain r=froydnj

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8861684c3209