Closed
Bug 1411168
Opened 8 years ago
Closed 8 years ago
Search XCUITests fail because now Search suggestion is on by default
Categories
(Firefox for iOS :: Build & Test, defect, P3)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 10.0 | --- |
People
(Reporter: isabel_rios, Assigned: isabel_rios)
References
Details
Attachments
(1 file)
New implementation landed on master in which Search suggestion is on by default.
It was off before so the tests now fail when checking that it is disabled. These are the tests affected:
testCopyPasteComplete()
testDismissPromptPresence()
testDoNotShowSuggestionsWhenEnteringURL()
testPromptPresence()
Working on a fix to update them.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → irios.mozilla
|
||
Updated•8 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 1•8 years ago
|
||
As confirmed in Bug 1411184, since Search suggestions is on by default, the prompt that was shown in the past is not needed anymore. One test about dismissing this prompt has been disabled and the other three that were failing have been modified.
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8921787 [details] [review]
Pull Request
These tests are now green, and also the rest
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/59f0476063056300016833d8#tests
Attachment #8921787 -
Flags: review?(npark)
|
|
||
Updated•8 years ago
|
Attachment #8921787 -
Flags: review?(npark) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Merged https://github.com/mozilla-mobile/firefox-ios/commit/07fc1f6435a2a5c6c847a3f49474d5477be66994
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [needsuplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•