1411185 - If only message part is an attachment, attachment gets saved with incorrect name (folder name for local folder and fetchUID.INBOX... for IMAP) - see comment #10

Status: RESOLVED DUPLICATE of bug 1528932

(MailNews Core :: MIME, defect)

Description

[Paolo Rossi Tiller]

Attachment: doc1.pdf

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce:

Saving an attached image (tiff) dragging it directly to a folder on my desktop (Windows 10)


Actual results:

Thunderbird create a fetchUID.INBOX54788 file in that folder instead of regular Tiff file.
If I rename that file with Tiff estension I can open it without problems.


Expected results:

Saving the image with correct name and extension.

Comment 1

[Jorg K (CEST = GMT+2)]

Interesting. You're using an IMAP account, I assume, since "fetch" and "UID" are used in IMAP. Does this happen with add-ons disabled? See Help menu.

Comment 2

[Paolo Rossi Tiller]

Yes, Imap account. I have no add-ons installed. All maintenance tasks done, like compatting and folder repair.

Regards
Paolo Rossi

Comment 3

[Jorg K (CEST = GMT+2)]

Gene, ever seen this?

Comment 4

[gene smith]

Does normal save-as for that file work ok? I mean without dragging.

Comment 5

[Paolo Rossi Tiller]

Yes, save as works normally.

Comment 6

[Paolo Rossi Tiller]

I tried under Windows 7, same problem.
I tried under MacOS and dragging works normally, no problem.
I don't know if it help.

Comment 7

[Jorg K (CEST = GMT+2)]

More questions: Does that only happen for images or also other attachments? Does it happen when you start Windows in safe mode? Does it happen for all messages with attached images or just a single or a few messages?

Comment 8

[Paolo Rossi Tiller]

1) Ok.. I try with many other emails with attached file like pdf, docx, xls, jpg, png.. NO problems..
2) I resend to myself with Outlook an email with the same tiff image previously saved with save-as.. and NOW it works!.. I can drag the attached file without any problem.

Maybe ther is something wrong inside the original email. I'll attach a zipped saved email.

Comment 9

[Paolo Rossi Tiller]

Attachment: zipped email with the problem

Comment 10

[Jorg K (CEST = GMT+2)]

Thanks, this clarifies the issue. The problem is that the message doesn't contain any text body, it only contains an image part. These are the headers:

From: Amalia <[e-mail]>
Content-Type: image/tiff; x-unix-mode=0644; name="foto amalia.tiff"
Content-Transfer-Encoding: base64
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: 
Message-Id: <[e-mail]>
Date: Tue, 24 Oct 2017 09:35:49 +0200
To: Paolo <[e-mail]>
Content-Disposition: inline; filename="foto amalia.tiff"
X-Mailer: Apple Mail (2.3273)

TU0AKgACRKSAP+BACCQWDQeEQmFQuGQ2HQ+IRGJROKRWLReMRmNRuOR2PR+QSGRSOSSWTSeUSmVS
uWS2XQuBP+XzOaTWbTecTmdTueT2fT+gUGhUOTTGiUekUmlUumU2nU+oVGpVOOUaqVesVmtVuuV2
...

In this case TB doesn't use the filename when dragging the file out onto the desktop.

Alfred, care to take a look where in MIME that problem is caused?

Comment 11

[Jorg K (CEST = GMT+2)]

BTW, I noticed those wrong file names when working on bug 1361422.

Comment 12

[Alfred Peters [:infofrommozilla]]

Jorg K (GMT+2) from comment #10)
> Alfred, care to take a look where in MIME that problem is caused?

In a normal multipart message, the name of the attachment is appended here as an addition to the URI:
<https://dxr.mozilla.org/comm-central/rev/97bf29612932b32707ddd6838047d364947eca13/mailnews/mime/src/mimemrel.cpp#522>

Here, this addition is stored in mAttachmentFileName.
<https://dxr.mozilla.org/comm-central/rev/97bf29612932b32707ddd6838047d364947eca13/mailnews/base/util/nsMsgMailNewsUrl.cpp#409>

mAttachmentFileName will later be used when saving the file.

But this is no multipart message. Therefore, the name was never parsed or stored.
And if mAttachmentFileName is't set, the IMAP-Folder+UID is used as filename.

Comment 13

[Jorg K (CEST = GMT+2)]

Thanks for the analysis so far. Where does the
> And if mAttachmentFileName isn't set, the IMAP-Folder+UID is used as filename.
happen? Any chance to get the real filename then?

Non-multipart messages a surely also parsed in some way. Can we pick up the filename then?

Comment 14

[Alfred Peters [:infofrommozilla]]

Attachment: b1411185.eml - Simplified mail from ZIP

I've created a simplified sample email.

With TB78.13:

• Save As: works fine
• Drag&Drop: is broken - The name becomes <IMAP-folder name>+<UID>

With TB91.03:

• Both cases works fine for me!

This was fixed for sure by bug 1528932