Dragging attachments of message onto the desktop sometimes use the mailbox name as filename (e.g. when attached.pdf is only Mime part)
Categories
(MailNews Core :: General, defect, P5)
Tracking
(thunderbird_esr78 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | wontfix |
People
(Reporter: jorgk-bmo, Assigned: admin)
References
Details
Attachments
(1 file, 1 obsolete file)
2.55 KB,
patch
|
admin
:
review+
|
Details | Diff | Splinter Review |
Drag "Foo.eml" from attachment 8850706 [details] from bug 1350080 or "google.com!xxxxxx.dk!1435536000!1435622399.zip" from attachment 8864261 [details] from bug 1361422 onto the desktop.
The filename used is the mailbox name, not the attachment name as shown in the attachment area.
Saving the message uses the correct name.
I remember looking at this at some stage, somehow the correct name isn't available at the time. Alfred, can you take a look.
Comment 2•4 years ago
•
|
||
Confirming on Win10, TB 78 and Daily 90.0a1 (2021-05-15) (64-bit), both with almost same symptoms.
STR
- Save test.eml from attachment 9222167 [details] to your hard disk.
- test.eml contains test.pdf as the only Mime part. That in itself does not disturb Thunderbird, and the msg seems to show correctly with blank body and pdf attachment.
- Standalone message case: File > Open > Saved message > test.eml from attachment 9222167 [details]
- drag attached
test.pdf
to OS folder
- Inbox message case: After step 2: Message > Copy to > Inbox
- drag attached
test.pdf
to OS folder
Actual
- Standalone message case: after drop,
test.pdf
gets saved as intact PDF with right base name, but wrong .eml extension (test.eml
). - Inbox message case: after drop,
test.pdf
gets saved as intact PDF with name of TB account folder + numberINBOX94364
(no extension). On Daily, filename isInbox
(without number).
Expected
- save dropped attachment with correct file name,
test.pdf
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Comment 6•4 years ago
•
|
||
(In reply to KN4CK3R from comment #5)
Should I add them only in my code or in the whole file?
Imho, only in your code, please. There are more than 62 occurrences of if
one-liners in this file, too much for a peripheral change. Better to do that in a dedicated followup bug. Keeping separate things separate also makes it easier to track where things went wrong if they do.
Comment 7•4 years ago
|
||
What Thomas said :-)
Also, you don't need to request another review for that code - the general convention is that 'nit' comments are just for little things that don't really affect the functioning. Typos, formatting, minor comment clarifications, etc... So if you upload a revised patch, you can just set the "r+" flag on it directly.
(and thanks very much for the fix!)
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e5df9561f1cf
fixed drag&drop attachment name for when e.g. when attached.pdf is only Mime part. r=benc
Updated•4 years ago
|
Description
•