Closed Bug 1411304 Opened 2 years ago Closed Last year

Fix sccache hit rate perfherder metric to use lowerIsBetter

Categories

(Firefox Build System :: General, defect, P2)

defect

Tracking

(firefox-esr60 fixed, firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed

People

(Reporter: ted, Assigned: igoldan)

Details

Attachments

(1 file)

We submit sccache stats to perfherder:
https://dxr.mozilla.org/mozilla-central/rev/ce1a86d3b4db161c95d1147676bbed839d7a4732/testing/mozharness/mozharness/mozilla/building/buildbase.py#1938

In bug 1411212 we saw:
Improvements:

100%  sccache hit rate summary windows-mingw32-32 debug taskcluster-m4.4xlarge     1.00 -> 0.00

...when this is actually a regression. Apparently we need to specify `lowerIsBetter: true` in the perfherder suite to make this work properly.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #0)
> We submit sccache stats to perfherder:
> https://dxr.mozilla.org/mozilla-central/rev/
> ce1a86d3b4db161c95d1147676bbed839d7a4732/testing/mozharness/mozharness/
> mozilla/building/buildbase.py#1938
> 
> In bug 1411212 we saw:
> Improvements:
> 
> 100%  sccache hit rate summary windows-mingw32-32 debug
> taskcluster-m4.4xlarge     1.00 -> 0.00
> 
> ...when this is actually a regression. Apparently we need to specify
> `lowerIsBetter: true` in the perfherder suite to make this work properly.

O_o but lower is *not* better.
Product: Core → Firefox Build System
Assignee: nobody → igoldan
Priority: -- → P2
Comment on attachment 9003046 [details]
Bug 1411304 - lowerIsBetter not true for sccache hit rate

Joel Maher ( :jmaher ) (UTC-4) has approved the revision.
Attachment #9003046 - Flags: review+
Pushed by igoldan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed26ed848a8e
lowerIsBetter not true for sccache hit rate r=jmaher
https://hg.mozilla.org/mozilla-central/rev/ed26ed848a8e
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.