Closed
Bug 1411361
Opened 7 years ago
Closed 7 years ago
Update builders to rust 1.22.0
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox58 wontfix, firefox59 fixed)
RESOLVED
FIXED
mozilla59
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(1 file)
Rust 1.22.0 is scheduled for stable release November 23, early in the Firefox 59 nightly cycle. When it is released, we should update official builds to use it.
Updated•7 years ago
|
status-firefox58:
--- → wontfix
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8931167 -
Flags: review?(core-build-config-reviews)
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8931167 [details]
Bug 1411361 - Update builders to rust 1.22.1.
https://reviewboard.mozilla.org/r/202250/#review207942
lgtm if it's good for you.
::: commit-message-960f5:7
(Diff revision 5)
> +
> +New stable release.
> +
> +We leave the win32 builds on rust 1.21.0 for now:
> +
> +- Building with 1.22.1 fails on win32 opt we think because
nit: the punctuation here is off to my eye. There needs to be something between "opt" and "we", I think.
Attachment #8931167 -
Flags: review+
Updated•7 years ago
|
Attachment #8931167 -
Flags: review?(core-build-config-reviews)
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8931167 [details]
Bug 1411361 - Update builders to rust 1.22.1.
https://reviewboard.mozilla.org/r/202250/#review207944
::: commit-message-960f5:7
(Diff revision 5)
> +
> +New stable release.
> +
> +We leave the win32 builds on rust 1.21.0 for now:
> +
> +- Building with 1.22.1 fails on win32 opt we think because
I'll add commas. Thanks for the quick review!
Comment hidden (mozreview-request) |
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08d8c0d46a44
Update builders to rust 1.22.1. r=nalexander
Comment 10•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•